Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consumed floating promises #836

Merged
merged 12 commits into from
Apr 14, 2022
Merged

fix: consumed floating promises #836

merged 12 commits into from
Apr 14, 2022

Conversation

bytemain
Copy link
Member

Types

  • 🐛 Bug Fixes

Background or solution

this close: #806

Changelog

fix extHost process start timing problem

@bytemain
Copy link
Member Author

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.16.10-next-1649926953.0 publish successful! You can install prerelease version via npm install [email protected] @bytemain

@bytemain bytemain added this to the 2.17 milestone Apr 14, 2022
@bytemain
Copy link
Member Author

/publish

@github-actions
Copy link
Contributor

🎉 Pre-Release version 2.16.10-next-1649929379.0 publish successful! You can install prerelease version via npm install [email protected] @bytemain

@codecov-commenter
Copy link

Codecov Report

Merging #836 (bf84b24) into main (c512d51) will increase coverage by 0.04%.
The diff coverage is 63.81%.

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   58.56%   58.61%   +0.04%     
==========================================
  Files        1211     1213       +2     
  Lines       75003    75118     +115     
  Branches    15593    15633      +40     
==========================================
+ Hits        43929    44030     +101     
- Misses      28319    28330      +11     
- Partials     2755     2758       +3     
Impacted Files Coverage Δ
...ackages/debug/src/browser/debug-session-manager.ts 67.00% <0.00%> (-0.23%) ⬇️
...ges/editor/src/browser/workbench-editor.service.ts 62.68% <0.00%> (-0.07%) ⬇️
packages/extension/src/common/index.ts 77.46% <ø> (ø)
...ges/extension/src/node/extension.service.client.ts 67.56% <0.00%> (ø)
packages/extension/src/node/index.ts 0.00% <0.00%> (ø)
...c/browser/abstract-resource-preference-provider.ts 83.33% <0.00%> (+0.09%) ⬆️
packages/search/src/common/content-search.ts 67.90% <ø> (ø)
...xt/src/browser/services/file-tree-model.service.ts 54.22% <30.00%> (+0.34%) ⬆️
...ages/file-service/src/node/file-service-watcher.ts 68.88% <40.00%> (-2.30%) ⬇️
...rences/src/browser/folders-preferences-provider.ts 65.77% <50.00%> (-0.90%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b9316c...bf84b24. Read the comment docs.

@bytemain
Copy link
Member Author

看起来 work 了:
image

Copy link
Member

@Aaaaash Aaaaash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erha19 erha19 merged commit 83b7588 into main Apr 14, 2022
@erha19 erha19 deleted the fix/floating-promises-1 branch April 14, 2022 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ExtensionService connection 时序问题
4 participants