Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve e2e test stability and add terminal test case #1710

Merged
merged 8 commits into from
Oct 8, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Sep 22, 2022

Types

  • ⏱ Tests

Background or solution

提升原有测试的稳定性,增加在终端创建文件后,文件树实时同步的测试案例

Changelog

improve e2e test stability and add terminal test case

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 57.68% // Head: 57.69% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (cf6ad3f) compared to base (ecb4569).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1710      +/-   ##
==========================================
+ Coverage   57.68%   57.69%   +0.01%     
==========================================
  Files        1269     1274       +5     
  Lines       78979    79357     +378     
  Branches    16528    16618      +90     
==========================================
+ Hits        45559    45785     +226     
- Misses      30405    30545     +140     
- Partials     3015     3027      +12     
Flag Coverage Δ
jsdom 52.54% <ø> (+0.01%) ⬆️
node 15.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.00% <0.00%> (-0.63%) ⬇️
...collaboration/src/browser/collaboration.service.ts 73.75% <0.00%> (-0.61%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 70.76% <0.00%> (-0.59%) ⬇️
packages/electron-basic/src/browser/index.ts 73.26% <0.00%> (-0.48%) ⬇️
packages/core-browser/src/bootstrap/app.ts 64.68% <0.00%> (-0.10%) ⬇️
packages/core-common/src/index.ts 100.00% <0.00%> (ø)
packages/core-common/src/electron.ts 100.00% <0.00%> (ø)
packages/terminal-next/src/common/render.ts 100.00% <0.00%> (ø)
packages/core-browser/src/menu/next/menu-id.ts 100.00% <0.00%> (ø)
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 94ac126 into main Oct 8, 2022
@erha19 erha19 deleted the test/e2e/improve-test branch October 8, 2022 07:34
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants