Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: improve select component and global color tokens style #1683

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

erha19
Copy link
Member

@erha19 erha19 commented Sep 20, 2022

Types

  • 💄 Style Changes

Background or solution

close #1678.

调整自定义 ColorToken 注册 fallback 色值,使框架更贴合主题效果

修改后:

image

image

Changelog

  • improve select component and global color tokens style

@erha19 erha19 linked an issue Sep 20, 2022 that may be closed by this pull request
Copy link
Member

@Ricbet Ricbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 57.58% // Head: 57.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cdb67ce) compared to base (a72de19).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.20    #1683   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files        1255     1255           
  Lines       78349    78360   +11     
  Branches    16406    16413    +7     
=======================================
+ Hits        45115    45125   +10     
  Misses      30237    30237           
- Partials     2997     2998    +1     
Flag Coverage Δ
jsdom 52.39% <100.00%> (+<0.01%) ⬆️
node 15.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/theme/src/common/color-tokens/custom/button.ts 100.00% <ø> (ø)
...kages/theme/src/common/color-tokens/custom/icon.ts 100.00% <100.00%> (ø)
...ages/theme/src/common/color-tokens/custom/input.ts 100.00% <100.00%> (ø)
...ges/theme/src/common/color-tokens/custom/select.ts 100.00% <100.00%> (ø)
...extension/src/hosted/api/sumi/ext.host.api.impl.ts 89.65% <0.00%> (-3.21%) ⬇️
...ion/src/browser/vscode/api/main.thread.treeview.ts 48.77% <0.00%> (+0.66%) ⬆️
packages/core-common/src/node/port.ts 47.76% <0.00%> (+2.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit d3c774e into v2.20 Sep 20, 2022
@erha19 erha19 deleted the style/improve-select-style branch September 20, 2022 13:40
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 亮色主题下看不清 下拉框的下拉按钮
2 participants