Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve editor focus behavior #1448

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Conversation

Aaaaash
Copy link
Member

@Aaaaash Aaaaash commented Aug 1, 2022

Types

  • 🐛 Bug Fixes

Background or solution

Changelog

  • 优化编辑器文件树及 tab 点击时的聚焦行为

Base automatically changed from v2.19 to main August 1, 2022 03:02
@Aaaaash Aaaaash changed the base branch from main to v2.19 August 1, 2022 08:55
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #1448 (e3280d0) into v2.19 (80943f7) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##            v2.19    #1448      +/-   ##
==========================================
- Coverage   57.92%   57.89%   -0.04%     
==========================================
  Files        1248     1248              
  Lines       77797    77688     -109     
  Branches    16236    16205      -31     
==========================================
- Hits        45067    44978      -89     
+ Misses      29808    29789      -19     
+ Partials     2922     2921       -1     
Flag Coverage Δ
jsdom 52.56% <100.00%> (-0.03%) ⬇️
node 15.88% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/file-tree-next/src/browser/file-tree.service.ts 68.55% <100.00%> (ø)
packages/core-common/src/node/port.ts 43.93% <0.00%> (-5.05%) ⬇️
packages/monaco/src/browser/schema-registry.ts 68.88% <0.00%> (-2.23%) ⬇️
packages/extension/src/hosted/worker.host.ts 81.70% <0.00%> (-1.43%) ⬇️
...erences/src/browser/preference-settings.service.ts 75.94% <0.00%> (-0.64%) ⬇️
...kages/theme/src/browser/workbench.theme.service.ts 70.76% <0.00%> (-0.59%) ⬇️
...kages/components/src/recycle-tree/tree/TreeNode.ts 69.08% <0.00%> (-0.42%) ⬇️
packages/theme/src/common/color-tokens/button.ts 100.00% <0.00%> (ø)
...ges/theme/src/common/color-tokens/custom/button.ts 100.00% <0.00%> (ø)
...ages/file-service/src/node/file-service-watcher.ts 69.54% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80943f7...e3280d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants