Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #721 - Allow space infiltration at space level, and fix #728 - Crash when adding ERV to ThermalZone #729

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Aug 27, 2024

Before

cannot assign a SpaceInfiltration:XXX object to a space, because they are loads, not definitions.

721_before

After: it works, and ERV doesn't crash

721_after

@jmarrec jmarrec requested a review from macumber August 27, 2024 12:55
@jmarrec jmarrec self-assigned this Aug 27, 2024
Copy link
Collaborator

@macumber macumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@jmarrec jmarrec added the Enhancement Request New feature or request label Aug 29, 2024
@jmarrec jmarrec merged commit d4fbeda into develop Aug 29, 2024
8 checks passed
@jmarrec jmarrec deleted the 721_SpaceInfiltration_at_space_level branch August 29, 2024 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Request New feature or request Library Version Bump ➕ Pull Request bumps OSM libraries severity - Minor Bug 🐤
Projects
None yet
2 participants