#612 - Display Name and CAD Object ID #715
Conversation
|
That looks great, I like a toggle but maybe on the tab itself? |
|
Theoretically speaking, this applies to space, surfaces, shading surfaces, thermal zones, etc etc. |
|
I implemented a Preferences checkbox to display Additional Properties or not. Currently applies to:
Please see this, and depending on whether this looks good or not, we can decide if we finish it up
Missing for completion:
|
| @@ -441,6 +444,7 @@ void OSDocument::createTab(int verticalId) { | |||
| m_verticalId = verticalId; | |||
|
|
|||
| bool isIP = m_mainWindow->displayIP(); | |||
| bool displayAdditionalProps = m_mainWindow->displayAdditionalProps(); | |||
There was a problem hiding this comment.
Does toggleDisplayAdditionalPropsClicked get emitted somewhere on startup if it is set?
There was a problem hiding this comment.
It's read from settings and passed around. I dont think it needs to be emitted
| @@ -498,6 +507,22 @@ void FacilityShadingGridController::addColumns(const QString& category, std::vec | |||
| boost::optional<std::function<void(model::ShadingSurface*)>>( | |||
| std::function<void(model::ShadingSurface*)>([](model::ShadingSurface* t_ss) { t_ss->remove(); })), | |||
| boost::optional<std::function<bool(model::ShadingSurface*)>>(), DataSource(allShadingSurfaces, true)); | |||
| } else if (field == DISPLAYNAME) { | |||
| addLoadNameColumn(Heading(QString(DISPLAYNAME), false, false), // heading | |||
There was a problem hiding this comment.
Maybe just addValueEditColumn would work here? Or addNameLineEditColumn? To show the value without the icon?
There was a problem hiding this comment.
Yeah probably. I'll look into it
I suppose we should have a toggle switch somewhere in the preferences...