Updates for SketchUp 2024 #714

macumber · 2024-05-17T03:31:34Z

@jmarrec if you want to look at getting the SketchUp Plug-In working on Mac maybe we could both work on this branch

The current issue I am seeing is in QCoreApplication* ApplicationSingleton::application(bool gui), getOpenStudioModuleDirectory is returning a bad path object.

macumber · 2024-05-18T00:15:54Z

It's loading in a debug build which doesn't help debug the issue but does show we're not too far off

macumber · 2024-05-18T05:03:04Z

Downgrading our version of Qt to 6.5.3 to match SketchUp (6.5.2) has enabled the plug-in to load for me on Windows. Really would be nice to get Qt out of the SketchUp Plug-in and just use native SketchUp dialogs. Have to rebuild the inspector gadget...

See openstudiocoalition/openstudio-sketchup-plugin#133 and https://github.com/openstudiocoalition/openstudio-sketchup-plugin/tree/html_inspector

macumber · 2024-05-18T05:13:06Z

.github/workflows/app_build.yml


 jobs:
  build:
-    # Note: as of 2021-01-29, this only works for push, not for pull request
-    # if: "!(contains(github.event.head_commit.message, 'skip') && contains(github.event.head_commit.message, 'ci'))"
+    if: ${{ github.event_name == 'push' || !github.event.pull_request.draft }}


@jmarrec what do you think about this? I can't remember when we would want to use 'skip' or 'ci' instead?

Hmm the way I have it now marking as "Ready to Review" doesn't trigger the build, I'll work on that.

Ok now it runs when marked ready for review

So you can push a commit with "[skip ci]" in the commit message and the run won't be triggered.

But this is now baked into github actions anyways; https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

macumber · 2024-05-19T16:56:23Z

@jmarrec I also updated to official 3.8.0 here

jmarrec · 2024-05-19T23:04:20Z

.github/workflows/app_build.yml


 env:
  BUILD_TYPE: Release
  BUILD_DOCUMENTATION: OFF
  BUILD_TESTING: ON
  BUILD_BENCHMARK: ON
  BUILD_PACKAGE: ON
-  QT_VERSION: 6.6.3
+  QT_VERSION: 6.5.3


Yikes. That's for sketchup using a different Qt then. How was it working before though? Is Qt a new sketchup dependency?

Ok I follow now. Sketchup was using Qt 5 until 2023.1 where it switched to Qt 6.

OpenStudio SketchUp Plug-in crashes on launch on Mac (x86_64 and ARM) with SketchUp 2023 openstudio-sketchup-plugin#133 (comment)

https://forums.sketchup.com/t/can-not-modify-window-style-on-sketchup-2023-1-by-win-api/241719

Yeah I don't really like having our Qt version tied to SketchUp's. That is the idea of eventually removing all the Qt stuff from the SketchUp Plug-in, the biggest thing to replace is the Inspector Dialog which is not that hard but it isn't trivial.

jmarrec · 2024-05-21T08:01:20Z

.github/workflows/app_build.yml

@@ -8,19 +8,20 @@ on:
      - 'v*' # Push events to matching v*, i.e. v1.0, v20.15.10
  pull_request:
    branches: [ master, develop ]
+    types: [ opened, reopened, synchronize, ready_for_review ]


Why do you want to add this?

They default types for pull_requests are [ opened, reopened, synchronize ]. I added ready_for_review in the case that a PR is draft and then you mark it ready for review without pushing a commit. The idea is if you want to push code to a branch but not kick off a bunch of CI builds you can mark the PR as draft. Then when you want CI to run you set as ready for review. To me that seems nicer than adding [skip ci] to each commit message but we could do that too.

jmarrec · 2024-05-21T08:02:09Z

.github/workflows/app_build.yml


 jobs:
  build:
-    # Note: as of 2021-01-29, this only works for push, not for pull request
-    # if: "!(contains(github.event.head_commit.message, 'skip') && contains(github.event.head_commit.message, 'ci'))"
+    if: ${{ github.event_name == 'push' || !github.event.pull_request.draft }}


So you can push a commit with "[skip ci]" in the commit message and the run won't be triggered.

But this is now baked into github actions anyways; https://docs.github.com/en/actions/managing-workflow-runs/skipping-workflow-runs

.github/workflows/app_build.yml

macumber · 2024-05-22T03:37:43Z

I like your change @jmarrec, you good to merge this or do you want to think some more on it?

jmarrec · 2024-05-22T14:38:25Z

I have a vague recollection of us bumping Qt 6 version to avoid a bug or two (display all black on macos with dark theme maybe?). it does pain me to downgrade qt (I'd rather bump up 6.7.x), but i really just want to make sure we aren't re-creating problems.

Do you have a guesstimate of the effort needed to port the IG / model_editor to native sketchup so we avoid binary mismatch ?

macumber · 2024-05-22T23:29:05Z

My guess is 15-20 hours for the inspector replacement, it would be a significant effort so I'd want to clear it with the OSC first. If it's worthwhile we can ask if that is in scope for next release. Otherwise we can go with this approach and maybe do the html inspector later. There will always be a binary compatibility issue with OpenStudio SDK and SketchUp due to Ruby version.

jmarrec · 2024-05-23T07:22:09Z

@macumber There's a decent change this will break this again:

OpenStudio Application unusable on MacOS14 with M2 #688

Is packaging the .so within the sketchup-plugin instead of asking for a path to the OSApp possible?

If so, perhaps we could be making the Qt version configurable, and only use 6.5.3 in specific workflows and use those binaries for Sketchup-plugin.
Obviously that would create a hassle for maintaining (gotta compile with both versions to ensure you don't use a method that's in Qt 6.7 and not in 6.5).

… box (dynamically)

jmarrec · 2024-05-23T07:54:33Z

ruby/openstudio_modeleditor.rb

+  if !File.exist?(File.join(qt_dll_path, 'Qt5Core.dll'))
    release_dll_path = File.expand_path(File.join(File.dirname(__FILE__), '../../Release/'))
    debug_dll_path = File.expand_path(File.join(File.dirname(__FILE__), '../../Debug/'))
-    if File.exists?(File.join(release_dll_path, 'Qt5Core.dll'))
+    if File.exist?(File.join(release_dll_path, 'Qt5Core.dll'))
      qt_dll_path = release_dll_path
-    elsif File.exists?(File.join(debug_dll_path, 'Qt5Core.dll'))
+    elsif File.exist?(File.join(debug_dll_path, 'Qt5Core.dll'))


Why are we looking for Qt5? I suppose "if install path fails" is always false then.

jmarrec · 2024-05-23T09:25:01Z

CMakeLists.txt

+set(QT_VERSION "6.5.3" CACHE STRING "Qt target version, defaults to 6.5.3")
+
+# For AboutBox, but also validates that the version is valid
+string(REGEX MATCH "^([0-9]+\\.[0-9]+)"
+  QT_VERSION_MAJOR_MINOR ${QT_VERSION})
+if(NOT QT_VERSION_MAJOR_MINOR)
+  message(FATAL_ERROR "Failed to match QT_VERSION=${QT_VERSION}")
+endif()
+set(QT_DOC_LINK "https://doc.qt.io/qt-${QT_VERSION_MAJOR_MINOR}/qtmodules.html")


Allow passing QT_VERSION... default to 6.5.3

Make a link for the aboutbox

ruby/openstudio_modeleditor.rb

src/openstudio_app/AboutBox.hpp.in

jmarrec · 2024-05-23T09:27:53Z

@bwinsatt @mioruggieroguida I'm worried that this PR will affect M2 users (#688). We do not have a M2/M3 machine for testing. Could you help us by testing the macos arm64 installer from https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/9204641443?pr=714 please? They are already up

…ories

macumber · 2024-05-26T17:25:42Z

SketchUp Plug-in is still not loading on Mac:

SketchUp is using Qt 6.5.2 and we are using 6.5.3, we may need to match their version exactly

…udioApplication into sketchup_2024

jmarrec · 2024-05-27T07:02:23Z

I had this error. sorry for the screenshot, I can't do anything else with this window open.

@bwinsatt unfortunately that's not our fault, it's the OS SDK, the "classic" subcommand for measure manager is broken

$ openstudio --version
3.8.0+f953b6fcaf
$ openstudio classic measure -s 8091
Error executing argv: ["measure", "-s", "8091"]
Error: cannot load such file -- webrick in eval:182:in `require'

webrick gem was removed from the standard library in Ruby 3...

Make sure you go to "Preferences" and uncheck the "Use Classic CLI" checkbox there. (@macumber we should probably remove it...)

Filed at: openstudio classic measure -s is broken (measure manager using classic CLI) in 3.8.0 NREL/OpenStudio#5212

macumber · 2024-05-27T17:37:40Z

Loading on SketchUp 2024 on Mac M1 now after matching Qt version exactly:

macumber · 2024-05-27T17:54:31Z

@bwinsatt can you try resetting your OpenStudio Application preferences manually using the workaround in #717 ?

Then after that, can you try downloading at using the package from:
https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/9258087440

Thank you so much for your help on this!

macumber · 2024-05-27T18:00:22Z

@jmarrec if @bwinsatt says this is good to go I think this is ready to merge.

jmarrec · 2024-05-27T19:27:26Z

Yeah @macumber merge at will after that.

bwinsatt · 2024-05-28T10:35:12Z

Can you clarify what I need to do to test on M2? I was able to install and open the application after following #717.

After opening, I get this error, but the application still is usable after clicking ok.

jmarrec · 2024-05-30T15:23:33Z

@bwinsatt That's all we needed, thanks!

that error will be resolved soon, it's an OS SDK issue.

macumber and others added 3 commits May 16, 2024 21:31

Updates for SketchUp 2024

bfcf310

One more File.exists

377c9d3

Fixup looking for system ruby for running tests

48d1f9d

Use same major and minor version of Qt as SketchUp

50f155a

macumber mentioned this pull request May 18, 2024

Update to Ruby3 openstudiocoalition/openstudio-sketchup-plugin#137

Merged

Don't run workflow if PR is draft

2751769

macumber commented May 18, 2024

View reviewed changes

macumber marked this pull request as ready for review May 18, 2024 17:10

macumber marked this pull request as draft May 18, 2024 17:11

Trigger CI when PR is marked ready for review

f0b8a25

macumber marked this pull request as ready for review May 19, 2024 16:05

Update to official 3.8.0 packages

598c17d

Update resources

fff53cf

jmarrec reviewed May 20, 2024

View reviewed changes

jmarrec reviewed May 21, 2024

View reviewed changes

jmarrec requested changes May 21, 2024

View reviewed changes

.github/workflows/app_build.yml Outdated Show resolved Hide resolved

Update .github/workflows/app_build.yml

55cfab6

jmarrec added 2 commits May 23, 2024 10:01

Unrelated update AboutBox and model_editor fallbacks for Qt6

6473833

Allow passing QT_VERSION (default 6.5.3) - Update Qt version in about…

d4f56e7

… box (dynamically)

jmarrec force-pushed the sketchup_2024 branch from fa95e2e to d4f56e7 Compare May 23, 2024 08:20

jmarrec reviewed May 23, 2024

View reviewed changes

macumber added 6 commits May 25, 2024 22:22

clang format

7d30090

Try the gtest/QApplication workaround

addfaf0

Missed this file

4e1dee8

Apply fix to benchmark as well, remove PathWatcher support for direct…

f35dda7

…ories

Clean up documentation

5dea4d3

Clang format

427d60d

macumber added 8 commits May 26, 2024 12:20

Move to Qt 6.5.2

03018ef

Fix ruby test

1157124

Merge branch 'sketchup_2024' of github.com:openstudiocoalition/OpenSt…

fbe0d12

…udioApplication into sketchup_2024

Try to fix tests on Ubuntu

dbaa0c4

libxcb -> libxcb-icccm4

6e95292

More libxcb

67dac8d

Remove missing packages

4ac00c2

Use versions that exist

1d8597a

jmarrec mentioned this pull request May 27, 2024

openstudio classic measure -s is broken (measure manager using classic CLI) in 3.8.0 NREL/OpenStudio#5212

Closed

macumber added 4 commits May 27, 2024 10:18

Temp disable other platforms to get remaining libxcb issues

ff6c20e

Add libxcb-shape

051b028

Finally got tests working on Ubuntu

4cd5ac0

Merge branch 'develop' into sketchup_2024

808ff08

jmarrec merged commit cf61365 into develop May 30, 2024
8 checks passed

jmarrec deleted the sketchup_2024 branch May 30, 2024 15:23

github-actions bot locked and limited conversation to collaborators May 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates for SketchUp 2024 #714

Updates for SketchUp 2024 #714

macumber commented May 17, 2024 •

edited

Loading

macumber commented May 18, 2024 •

edited

Loading

macumber commented May 18, 2024 •

edited

Loading

macumber May 18, 2024

macumber May 18, 2024

macumber May 19, 2024

jmarrec May 21, 2024

macumber commented May 19, 2024

jmarrec May 19, 2024 •

edited

Loading

jmarrec May 21, 2024

macumber May 22, 2024

jmarrec May 21, 2024

macumber May 22, 2024

jmarrec May 21, 2024

macumber commented May 22, 2024

jmarrec commented May 22, 2024

macumber commented May 22, 2024

jmarrec commented May 23, 2024

jmarrec May 23, 2024

jmarrec May 23, 2024

jmarrec commented May 23, 2024 •

edited

Loading

macumber commented May 26, 2024

jmarrec commented May 27, 2024 •

edited

Loading

macumber commented May 27, 2024

macumber commented May 27, 2024

macumber commented May 27, 2024

jmarrec commented May 27, 2024

bwinsatt commented May 28, 2024

jmarrec commented May 30, 2024

Updates for SketchUp 2024 #714

Updates for SketchUp 2024 #714

Conversation

macumber commented May 17, 2024 • edited Loading

macumber commented May 18, 2024 • edited Loading

macumber commented May 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macumber commented May 19, 2024

jmarrec May 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

macumber commented May 22, 2024

jmarrec commented May 22, 2024

macumber commented May 22, 2024

jmarrec commented May 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmarrec commented May 23, 2024 • edited Loading

macumber commented May 26, 2024

jmarrec commented May 27, 2024 • edited Loading

macumber commented May 27, 2024

macumber commented May 27, 2024

macumber commented May 27, 2024

jmarrec commented May 27, 2024

bwinsatt commented May 28, 2024

jmarrec commented May 30, 2024

macumber commented May 17, 2024 •

edited

Loading

macumber commented May 18, 2024 •

edited

Loading

macumber commented May 18, 2024 •

edited

Loading

jmarrec May 19, 2024 •

edited

Loading

jmarrec commented May 23, 2024 •

edited

Loading

jmarrec commented May 27, 2024 •

edited

Loading