Update to OpenStudio 3.7.0-alpha based on EnergyPlus v23.2.0 official #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows build is stuck on CI, arm64 mac will be uploaded soon but SHA is already correct
jmarrec
commented
Oct 2, 2023
| @@ -53,7 +53,7 @@ | |||
| #include <openstudio/model/PumpVariableSpeed.hpp> | |||
| #include <openstudio/model/CoilCoolingWater.hpp> | |||
| #include <openstudio/model/CoilHeatingWater.hpp> | |||
| #include <openstudio/model/DistrictHeating.hpp> | |||
| #include <openstudio/model/DistrictHeatingWater.hpp> | |||
There was a problem hiding this comment.
I don't understand why we have these includes here in OpenStudioApp.hpp / OpenStudioApp.cpp
| @@ -1087,7 +1087,7 @@ void MainRightColumnController::configureForHVACSystemsSubTab(int subTabID) { | |||
| libraryWidget->addModelObjectType(IddObjectType::OS_EvaporativeFluidCooler_SingleSpeed, "Evaporative Fluid Cooler Single Speed"); | |||
| libraryWidget->addModelObjectType(IddObjectType::OS_Duct, "Duct"); | |||
| libraryWidget->addModelObjectType(IddObjectType::OS_DistrictCooling, "District Cooling"); | |||
| libraryWidget->addModelObjectType(IddObjectType::OS_DistrictHeating, "District Heating"); | |||
| libraryWidget->addModelObjectType(IddObjectType::OS_DistrictHeating_Water, "District Heating Water"); | |||
There was a problem hiding this comment.
DistrictHeating was renamed to DistrictHeatingWater
Comment on lines
+347
to
+348
| // Gotta help the compiler here, since there is a `bool setFuelType(const std::string&)` and a `bool setFuelType(const FuelType&)` overload | ||
| CastNullAdapter<model::ExteriorFuelEquipment, bool, std::string>(&model::ExteriorFuelEquipment::setFuelType), |
There was a problem hiding this comment.
it has a new overload for setFuelType, so I had to nudge the compiler into selecting the right template arguments
There was a problem hiding this comment.
Added a script to detect outdated fields in OpenStudioPolicy.
I also used it to add some missing ones (lots of "Crankcase Heater" Curves were added to SDK), not sure if that's really warranted on not.
jmarrec
commented
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use the nightly from last friday (or today, develop hasn't changed since then)