Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variables layout #631

Merged
merged 5 commits into from
Sep 10, 2023
Merged

Update variables layout #631

merged 5 commits into from
Sep 10, 2023

Conversation

macumber
Copy link
Collaborator

@macumber macumber commented Sep 6, 2023

Fixes #626

I just moved things around a little bit, I also added a progress bar when editing all the variables.
image

@macumber macumber requested a review from jmarrec September 6, 2023 00:16
@jmarrec
Copy link
Collaborator

jmarrec commented Sep 6, 2023

Thanks @macumber. I'm fine with the changes, except the combobox for picking "", "Enabled", "Disabled".

I'd rather have several buttons.

Maybe "View: [All] [Enabled] [Disabled]", only one button is pressed at the same time, same a the ["Layout", "Grid", "Control"] buttons on the HVAC tab.

Either on its own line, or with some kind of separator from the Filter box, I find the position of the existing combobox to be confusing.


Also, the progress bar is useless at least on my machine, even having enabled all variables and then switching the frequency, the only thing I see on the display is the mere flicker of a progressbar.

Edit: Ok, I see the progressbar is potentially useful when toggle variables On/off

Let's agree on the design before either of us makes the change.

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 6, 2023

Alternative 1

redo_out_var

Atlernative2

probably clearer in that order:

image

Alternative 3

image

alternative 4

image

@macumber
Copy link
Collaborator Author

macumber commented Sep 7, 2023

Wow @jmarrec so many options! I like Atlernative4, I'd just get rid of the big blank space between the buttons and the vertical separatr. We can remove the progress bar for bulk updating frequency if you want, it's most useful for bulk turning variables on (which really just makes a bunch of model objects).

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 7, 2023

image

@jmarrec jmarrec force-pushed the update_variables_layout branch from 2e3e5b4 to c79f27d Compare September 7, 2023 14:33
@macumber
Copy link
Collaborator Author

macumber commented Sep 9, 2023

Looks great!

@jmarrec
Copy link
Collaborator

jmarrec commented Sep 9, 2023

The macos-12 failed because of cpack, I haven't seen that before. https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/6132515635/job/16643468685?pr=631#step:19:1001

Unrelated to this PR I'm pretty sure

@macumber
Copy link
Collaborator Author

macumber commented Sep 9, 2023

GitHub updates these runner images all the time, I wonder if something changed to break this, they have release notes at https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md. It looks like it affects the tar.gz package only so I'll try disabling that for MacOS for now

@macumber macumber merged commit 502d777 into develop Sep 10, 2023
@macumber macumber deleted the update_variables_layout branch September 10, 2023 02:06
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redo the layout of the new Output:Variable filter capability
2 participants