-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update variables layout #631
Conversation
Thanks @macumber. I'm fine with the changes, except the combobox for picking "", "Enabled", "Disabled". I'd rather have several buttons. Maybe "View: [All] [Enabled] [Disabled]", only one button is pressed at the same time, same a the ["Layout", "Grid", "Control"] buttons on the HVAC tab. Either on its own line, or with some kind of separator from the Filter box, I find the position of the existing combobox to be confusing. Also, the progress bar is useless at least on my machine, even having enabled all variables and then switching the frequency, the only thing I see on the display is the mere flicker of a progressbar. Edit: Ok, I see the progressbar is potentially useful when toggle variables On/off Let's agree on the design before either of us makes the change. |
Wow @jmarrec so many options! I like Atlernative4, I'd just get rid of the big blank space between the buttons and the vertical separatr. We can remove the progress bar for bulk updating frequency if you want, it's most useful for bulk turning variables on (which really just makes a bunch of model objects). |
2e3e5b4
to
c79f27d
Compare
Looks great! |
The macos-12 failed because of cpack, I haven't seen that before. https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/6132515635/job/16643468685?pr=631#step:19:1001 Unrelated to this PR I'm pretty sure |
GitHub updates these runner images all the time, I wonder if something changed to break this, they have release notes at https://github.com/actions/runner-images/blob/main/images/macos/macos-12-Readme.md. It looks like it affects the tar.gz package only so I'll try disabling that for MacOS for now |
Fixes #626
I just moved things around a little bit, I also added a progress bar when editing all the variables.