Geometry Preview refactor - separate into several files, allow running in browser directly #628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Download the unminified version too for those I could locate
…ng changes so use TweenLite 2.x) https://github.com/greensock/GSAP
jmarrec
added
Enhancement Request
|
This looks great @jmarrec, as an FYI, I've tried to keep the html and code here in sync with:
NREL uses those measures to view models from PAT, etc. If NREL is willing to support you doing it could you consider porting these changes back to the |
jmarrec
added a commit
to NREL/openstudio-common-measures-gem
that referenced
this pull request
Aug 29, 2023
openstudiocoalition/OpenStudioApplication#628 * Extract the inline jS from geometry_preview.html into separate jS files * Upgrades these dependencies (to a version without major breaking changes), and downloads the unminified version that matches, so one could technically swap to these to debug something * Be explicit about which versions of these dependencies we use * Allows running the geometry_preview in your browser directly with some json data. * Add separate entry points `runFromJSON` and `runFromFile` openstudiocoalition/OpenStudioApplication#629 * Opt-in feature to enable the geometry diagnostics from this PR:
|
Backported at NREL/openstudio-common-measures-gem#156 Tested the measures locally + inside the OS App (I ended up embedding the jS files + data into the report.html to avoid issues) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find the geometry_preview.html awful to work with, as it has a lot of embedded jS into it.
Also, having the ability to run it directly into your browser is helpful for testing out changes.
This PR:
runFromJSONandrunFromFile