Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #560 - Refactor HVACSystems view to hide unavailable controls, allow zooming display on VRF + Refrigeration tab #622

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Aug 22, 2023

  • Fix HVAC tab for VRF does not zoom #560

  • Allow zooming the display on the VRF and on the Refrigeration tabs

    • Zoom is reset when you switch to/from the system list view from/to the detailed view
  • Replace the buttons to expand a system / move back up to the systems list view (+ tooltip)

  • Hide the "Control" and "Grid" buttons when they aren't available.

    • When you were on it and switch to a system type (VRF / SHW, Refrigeration) for which it isn't available, you see the tab that says it's not available, the button is there to make it clear you're on it. As soon as you switch to a valid tab, it disappears.

Here is a GIF showing the new UI:

560_zoom_VRF_Refrigeration

Allow zooming with CTRL + WheelUp/Down or CTRL + '+' / '-'

vrf_zooming_with_CTRL

@jmarrec jmarrec self-assigned this Aug 22, 2023
@jmarrec jmarrec requested a review from macumber August 22, 2023 13:53
@jmarrec
Copy link
Collaborator Author

jmarrec commented Aug 28, 2023

I'm going to merge this, we can refactor the logic in a second PR.

@jmarrec jmarrec merged commit bc897d8 into develop Aug 28, 2023
@jmarrec jmarrec deleted the 560_Zoom_VRF_Refrigeration branch August 28, 2023 10:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HVAC tab for VRF does not zoom
2 participants