Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

render scene when camera option changes #586

Merged
merged 1 commit into from
Dec 30, 2022
Merged

render scene when camera option changes #586

merged 1 commit into from
Dec 30, 2022

Conversation

antoine-galataud
Copy link
Contributor

Fixes #585

@antoine-galataud antoine-galataud mentioned this pull request Dec 30, 2022
Closed
macumber
macumber approved these changes Dec 30, 2022
View reviewed changes
Copy link
Collaborator

@macumber macumber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@macumber
Copy link
Collaborator

Mac failures are due to certificate expiring on https://gmplib.org/

@macumber macumber merged commit 8444dd5 into openstudiocoalition:develop Dec 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macumber macumber macumber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Geometry camera options don't trigger scene rendering
2 participants
@antoine-galataud @macumber