Adding Mac Mini runner for arm64 (M1) packages #578

macumber · 2022-11-26T20:06:08Z

No description provided.

macumber · 2022-11-26T21:21:18Z

@jmarrec getting this error when trying to run the OS 3.5.0 CLI on Mac Mini with M1 processor

(py39)irvinemac@~$ /Users/irvinemac/git/OSApp-build/OpenStudio-3.5.0/OpenStudio-3.5.0+7b14ce1588-Darwin-arm64/bin/openstudio
dyld: Symbol not found: __ZNKSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE3strEv
  Referenced from: /Users/irvinemac/git/OSApp-build/OpenStudio-3.5.0/OpenStudio-3.5.0+7b14ce1588-Darwin-arm64/bin/../lib/libopenstudiolib.dylib (which was built for Mac OS X 12.1)
  Expected in: /usr/lib/libc++.1.dylib

Might be because the Mac Mini was on OS 11.6 (20G165), I'll update it

Updating the Mac Mini to 13.0.1 fixed the build issues!

macumber · 2022-11-27T18:03:06Z

It's odd that my commits from the Mac Mini are showing up as you @jmarrec, I generated and used a new token under my account to do the commits. I guess I need to change the global config too.

jmarrec · 2022-11-28T12:23:18Z

I'm downloading the dmg package for arm64 and will test it on my machine to make sure it works. OpenStudioApplication-1.4.1.758c1c5864d6b42ecb9ca3a8dd8a1ece2682a1c9-macos-arm64.dmg

I'm getting an issue with the Measure Manager, this is probably not due to this specific PR though.

$ OPENSTUDIO_APPLICATION_DEBUG=1 /Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp
[OpenStudioApplicationPathHelpers] <-2> getOpenStudioApplicationModule, info.dli_fname = '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[PathHelpers] <-2> completeAndNormalize: result = /Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp
[ApplicationPathHelpers] <-2> getOpenStudioApplicationModule, found '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[OpenStudioApplicationPathHelpers] <-2> Searching for CLI in '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/OpenStudio-3.5.0/OpenStudio-3.5.0+7b14ce1588-Darwin-arm64/bin/openstudio'
[OpenStudioApplicationPathHelpers] <-2> getOpenStudioApplicationModule, info.dli_fname = '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[PathHelpers] <-2> completeAndNormalize: result = /Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp
[ApplicationPathHelpers] <-2> getOpenStudioApplicationModule, found '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[OpenStudioApplicationPathHelpers] <-2> Searching for CLI in '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/../bin/openstudio'
[openstudio.OSAppBase] <-2> Starting measure manager server at http://127.0.0.1:50139
[OpenStudioApplicationPathHelpers] <-2> getOpenStudioApplicationModule, info.dli_fname = '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[PathHelpers] <-2> completeAndNormalize: result = /Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp
[ApplicationPathHelpers] <-2> getOpenStudioApplicationModule, found '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[OpenStudioApplicationPathHelpers] <-2> Searching for CLI in '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/OpenStudio-3.5.0/OpenStudio-3.5.0+7b14ce1588-Darwin-arm64/bin/openstudio'
[OpenStudioApplicationPathHelpers] <-2> getOpenStudioApplicationModule, info.dli_fname = '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[PathHelpers] <-2> completeAndNormalize: result = /Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp
[ApplicationPathHelpers] <-2> getOpenStudioApplicationModule, found '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/OpenStudioApp'
[OpenStudioApplicationPathHelpers] <-2> Searching for CLI in '/Applications/OpenStudioApplication-1.4.1-alpha/OpenStudioApp.app/Contents/MacOS/../bin/openstudio'
[openstudio.OSAppBase] <-2> Command:  measure -s 50139
Warning: QIODevice::read (QProcess): device not open ((null):0, (null))
Warning: QIODevice::read (QProcess): device not open ((null):0, (null))

jmarrec · 2022-11-28T12:45:27Z

I had botched the configure of thre OpenStudioApplicationPathHelpers.cxx.in in #566, c90605e should fix it

jmarrec · 2022-11-28T12:11:32Z

.github/workflows/app_build.yml

+          COMPRESSED_EXT: tar.gz
+          BINARY_PKG_PATH: _CPack_Packages/Darwin/IFW
+          COMPRESSED_PKG_PATH: _CPack_Packages/Darwin/TGZ
+          MACOSX_DEPLOYMENT_TARGET: 10.14


This is probably too old really. I build the E+ and OS SDK with MACOSX_DEPLOYMENT_TARGET=12.1 on my machine.

Hmm, I see 10.15 in both EnergyPlus and OpenStudio. Agree that we could be less accommodating if we need, I'd say we update to 10.15 unless there are problems in 10.15 and then go to 11.

I build the arm64 packages myself, so that's local to my machine. see https://github.com/NREL/EnergyPlus/releases/tag/v22.2.0 for eg, you'll see the (only) arm64 package has 12.1 in the name.

Couple of datapoints:

Release dates:

Big Sur: November 12, 2020

Mac Mini M1 2020: November 17, 2020

Monterey: October 25, 2021

Macbook Pro 2021 M1: October 25, 2021

The Mac Mini (M1, 2020), which was as far as I know the first commercial M1 mac, was on Big Sur, so 11.x. At that point in time, I used Irvine's mac mini to build E+ package, and set the deployment target to 11.2.

My MBP M1 shipped with Monterrey (12.x)

I reckon people with M1 machines are more likely to be on the bleeding edge anyways.

So I figured I could just bump to 12.1, to match the macos-12 github actions runner. (I may have had another reason that is escaping me at the moment).

Yeah I get linker warnings that 12.1 is newer than the target 11.0 when I link with the OpenStudio build, did you build the OpenStudio packages for M1 with 12.1 too?

warning: dylib (../../OpenStudio-3.5.0/OpenStudio-3.5.0+7b14ce1588-Darwin-arm64/lib/libopenstudiolib.dylib) was built for newer macOS version (12.1) than being linked (11.0)

If so, I guess there is no reason to try to be more backward compatible than OpenStudio is. Looks like the conan stuff is being built for 11.2.

jmarrec · 2022-11-28T13:21:51Z

.github/workflows/app_build.yml

+          if [ "${{matrix.SELF_HOSTED}}" = "true" ]; then
+            echo "Using previously installed ninja and IFW"
+            echo "/Users/irvinemac/Qt/Tools/QtInstallerFramework/4.3/bin/" >> $GITHUB_PATH
+          else


All that stuff should just be preconfigured on the machine perhaps? And we can just skip the step entirely if self hosted

(maybe we should have a dedicated workflow yml file for the self hosted?)

I thought about both of those. I wanted to try the caching and see how it goes, seems like it's not worth it. I'd prefer to keep a single workflow file otherwise I'm sure they'll diverge.

.github/workflows/app_build.yml

jmarrec · 2022-11-29T16:33:22Z

Still having an issue with the packaging. Not the fault of this PR I think, though I do see packaging CPACK issuing errors: https://github.com/openstudiocoalition/OpenStudioApplication/actions/runs/3575395655/jobs/6011876669#step:19:1009

CMake Error: failed to create symbolic link '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/_CPack_Packages/Darwin/IFW/OpenStudioApplication-1.4.1-alpha+e611bc884a-macOS11-arm64/packages/Unspecified/data/OpenStudioApp.app/Contents/Frameworks/QtWebEngineCore.framework/Versions/A/Helpers/QtWebEngineProcess.app/Contents/Frameworks': No such file or directory
CMake Error: failed to create symbolic link '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/_CPack_Packages/Darwin/IFW/OpenStudioApplication-1.4.1-alpha+e611bc884a-macOS11-arm64/packages/Unspecified/data/OpenStudioApp.app/Contents/EnergyPlus': No such file or directory
CMake Error: failed to create symbolic link '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/_CPack_Packages/Darwin/IFW/OpenStudioApplication-1.4.1-alpha+e611bc884a-macOS11-arm64/packages/Unspecified/data/OpenStudioApp.app/Contents/Radiance': No such file or directory
CMake Error: failed to create symbolic link '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/_CPack_Packages/Darwin/IFW/OpenStudioApplication-1.4.1-alpha+e611bc884a-macOS11-arm64/packages/Unspecified/data/OpenStudioApp.app/Contents/Frameworks/libpythonengine.so': No such file or directory
CMake Error: failed to create symbolic link '/Users/irvinemac/actions-runner/_work/OpenStudioApplication/OpenStudioApplication/build/_CPack_Packages/Darwin/IFW/OpenStudioApplication-1.4.1-alpha+e611bc884a-macOS11-arm64/packages/Unspecified/data/OpenStudioApp.app/Contents/Frameworks/librubyengine.so': No such file or directory

macumber · 2022-12-03T01:20:28Z

Hmm I don't see those errors when building locally in the home directory, I'll look into it. Nevermind, when I configured for IFW I see the error

macumber · 2022-12-03T19:25:41Z

@jmarrec the symlinks were being installed in the Unspecified component instead of OpenStudioApp. There were also some issues after updating Xcode but I think those are good now. Do these packages work for you now?

… in installer

ProjectMacros.cmake

jmarrec · 2022-12-05T17:18:20Z

Sorry about the closing / reopening, I misclicked by accident... I'm testing out the package right now, will report back.

jmarrec · 2022-12-05T17:21:08Z

@jmarrec the symlinks were being installed in the Unspecified component instead of OpenStudioApp. There were also some issues after updating Xcode but I think those are good now. Do these packages work for you now?

All good apparently! Thanks @macumber !

macumber and others added 7 commits November 26, 2022 13:05

Adding runner

a297b56

Correct key

bfb2faa

Only run on mini for faster cycle

5ab8c4f

Skip setup for self hosted

c2d222c

Correct syntax

cac9a6b

Remove other OS's temporarily

be8a2d3

Find Qt

70cb3f5

jmarrec and others added 4 commits November 26, 2022 21:37

Add step back for self hosted

1891363

Bash needs its space

93ac7d9

Add other os's back in

9254d13

Upgrade more Node12 actions

df0881e

macumber added 3 commits November 27, 2022 11:05

Update to Mac OS 12

6e24d55

Update the os below

d1fd12e

Change OS name for Arm64

09b726e

Fix the getOpenStudioCoreCLI that I botched in #566

c90605e

jmarrec added 2 commits November 28, 2022 09:18

Use all available cores on linux/mac (including the self hosted one)

0fc7d71

Define N as a nproc for all platforms

8d790f4

jmarrec reviewed Nov 28, 2022

View reviewed changes

macumber added 2 commits November 28, 2022 18:24

Don't cache on self hosted

b30ad2f

Update minimum mac to OpenStudio/EnergyPlus version 10.15 and M1 to 11.0

f6ed3ed

Fix symlinks

a17c1d2

macumber added 2 commits December 3, 2022 19:08

Allow unit tests and OSApp to run in build dir, rpath gets removed up…

d8b7cf9

… in installer

Bump min OSX version to 12.1 to match OpenStudio

40e42ec

macumber requested a review from jmarrec December 4, 2022 04:49

jmarrec reviewed Dec 5, 2022

View reviewed changes

ProjectMacros.cmake Show resolved Hide resolved

jmarrec closed this Dec 5, 2022

jmarrec reopened this Dec 5, 2022

github-actions bot locked and limited conversation to collaborators Dec 5, 2022

openstudiocoalition unlocked this conversation Dec 5, 2022

macumber merged commit c019265 into develop Dec 6, 2022

macumber deleted the macmini_runner branch December 6, 2022 04:16

github-actions bot locked and limited conversation to collaborators Dec 6, 2022

jmarrec changed the title ~~Adding Mac Mini runner~~ Adding Mac Mini runner for arm64 (M1) packages Dec 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding Mac Mini runner for arm64 (M1) packages #578

Adding Mac Mini runner for arm64 (M1) packages #578

macumber commented Nov 26, 2022

macumber commented Nov 26, 2022 •

edited

Loading

macumber commented Nov 27, 2022

jmarrec commented Nov 28, 2022

jmarrec commented Nov 28, 2022

jmarrec Nov 28, 2022

macumber Nov 29, 2022

jmarrec Nov 29, 2022 •

edited

Loading

macumber Dec 4, 2022

jmarrec Nov 28, 2022

jmarrec Nov 28, 2022

macumber Nov 29, 2022

jmarrec commented Nov 29, 2022

macumber commented Dec 3, 2022 •

edited

Loading

macumber commented Dec 3, 2022

jmarrec commented Dec 5, 2022

jmarrec commented Dec 5, 2022

Adding Mac Mini runner for arm64 (M1) packages #578

Adding Mac Mini runner for arm64 (M1) packages #578

Conversation

macumber commented Nov 26, 2022

macumber commented Nov 26, 2022 • edited Loading

macumber commented Nov 27, 2022

jmarrec commented Nov 28, 2022

jmarrec commented Nov 28, 2022

jmarrec Nov 28, 2022

Choose a reason for hiding this comment

macumber Nov 29, 2022

Choose a reason for hiding this comment

jmarrec Nov 29, 2022 • edited Loading

Choose a reason for hiding this comment

macumber Dec 4, 2022

Choose a reason for hiding this comment

jmarrec Nov 28, 2022

Choose a reason for hiding this comment

jmarrec Nov 28, 2022

Choose a reason for hiding this comment

macumber Nov 29, 2022

Choose a reason for hiding this comment

jmarrec commented Nov 29, 2022

macumber commented Dec 3, 2022 • edited Loading

macumber commented Dec 3, 2022

jmarrec commented Dec 5, 2022

jmarrec commented Dec 5, 2022

macumber commented Nov 26, 2022 •

edited

Loading

jmarrec Nov 29, 2022 •

edited

Loading

macumber commented Dec 3, 2022 •

edited

Loading