Fix #535 - Combobox offset when using fractional scaling #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Jun 7, 2022
|
The only glitch I can see is this:
Versus with RoundPreferDown
|
…earGradient, icon and text to void antialiasing issues
|
I replaced the gradient image (1px wide) + image header (icon + pixelised text) by the icon, a QLinearGradient and some text placed by the QPainter: Before:
After:
|
|
Final result with Muli-Regular embedded (that's what's used on the https://openstudiocoalition.org/)
|
macumber
reviewed
Jun 8, 2022
| @@ -159,14 +161,29 @@ void OSDialog::paintEvent(QPaintEvent* event) { | |||
|
|
|||
| painter.setRenderHint(QPainter::Antialiasing); | |||
|
|
|||
| QImage centerHeader = QImage(":/images/header-backgnd-1px-wide.png"); | |||
There was a problem hiding this comment.
Awesome, we should nuke this png at some point
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: investigate side effects / display glitches this brings?
This only happens when you use Fractional Scaling, eg 250%. It works at 200% or 300%.
See this MCVE: https://github.com/jmarrec/QtTestbed/tree/main/Test-Combobox-Popup-Issue
And the bug report I filed at Qt's issue tracker: https://bugreports.qt.io/browse/QTBUG-104073