Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #522 - Too many new lines in Verbose output on the Run tab on Windows #543

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Fix #522 - Too many new lines in Verbose output on the Run tab on Windows #543

merged 1 commit into from
Jun 8, 2022

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented Jun 7, 2022

@jmarrec jmarrec added this to the OpenStudio Application 1.4.0 milestone Jun 7, 2022
@jmarrec jmarrec requested a review from macumber June 7, 2022 08:47
@jmarrec jmarrec self-assigned this Jun 7, 2022
jmarrec
jmarrec commented Jun 7, 2022
View reviewed changes
src/openstudio_lib/RunTabView.cpp
// DLM: coordinate with openstudio-workflow-gem\lib\openstudio\workflow\adapters\output\socket.rb
if (trimmedLine.isEmpty()) {
continue;
} else if ((trimmedLine.contains("DEBUG")) || (trimmedLine.contains("] <-2>"))) {
m_textInfo->setFontPointSize(10);
m_textInfo->setTextColor(Qt::lightGray);
m_textInfo->append(line);
m_textInfo->append(trimmedLine);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://doc.qt.io/qt-6/qtextedit.html#append

void QTextEdit::append(const QString &text)

Appends a new paragraph with text to the end of the text edit.

So trimmedLine is perfectly good here.

I tested on Windows and it fixes the issue. I tested on mac that it didn't create new problems.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jmarrec jmarrec merged commit b85cf73 into develop Jun 8, 2022
@jmarrec jmarrec deleted the 522_NewLines_RunTabView branch June 8, 2022 00:04
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macumber macumber Awaiting requested review from macumber

Assignees

@jmarrec jmarrec

Labels
component - UI
Projects
None yet
Milestone
OpenStudio Application 1.4.0
Development

Successfully merging this pull request may close these issues.

Too many new lines in Verbose output on the Run tab on Windows
2 participants
@jmarrec @macumber