Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#479 - Find outdated measures in your local BCL folder compared to Online BCL #517

Merged
merged 2 commits into from
May 5, 2022
Merged

#479 - Find outdated measures in your local BCL folder compared to Online BCL #517

merged 2 commits into from
May 5, 2022

Conversation

jmarrec
Copy link
Collaborator

@jmarrec jmarrec commented May 4, 2022

Kapture 2022-05-05 at 01 16 24

@jmarrec jmarrec requested a review from macumber May 4, 2022 23:17
@jmarrec jmarrec self-assigned this May 4, 2022
macumber
macumber reviewed May 5, 2022
View reviewed changes
src/shared_gui_components/MeasureManager.cpp
auto remoteBCL = new RemoteBCL();
int numUpdates = remoteBCL->checkForMeasureUpdates();
RemoteBCL remoteBCL;
int numUpdates = remoteBCL.checkForMeasureUpdates();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bizarre that we only called this here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bizarre it's actually never called anywhere. There's a lot of cruft in the codebase, cleaning it up at some point would be nice...

@macumber
Copy link
Collaborator

macumber commented May 5, 2022

I guess a future enhancement would be to allow selectively updating certain measures from the measure dialog, that would be a new enhancement though. This is great.

@jmarrec
Copy link
Collaborator Author

jmarrec commented May 5, 2022

I guess a future enhancement would be to allow selectively updating certain measures from the measure dialog, that would be a new enhancement though. This is great.

a future enhancement might be to adjust where the trigger is, and perhaps the UI and do something similar to the "Sync project measures" dialog.

As far as being able to individually select measures, I'm not sure what the use case would be. IMHO your local ~/BCL folder should be kept in sync with the remote BCL. If you need to have another version, then make a copy to your local ~/OpenStudio/Measures directory, no?

@jmarrec jmarrec merged commit 10f5c92 into develop May 5, 2022
@jmarrec jmarrec deleted the 479_FindOutdated_local_BCL branch May 5, 2022 07:00
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@macumber macumber macumber approved these changes

Assignees

@jmarrec jmarrec

Labels
component - Backend component - UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Measure updates on BCL don't work
2 participants
@jmarrec @macumber