366 geometry editor map #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
reviewed
May 31, 2021
| @@ -1156,8 +1156,8 @@ EditorWebView::EditorWebView(bool isIP, const openstudio::model::Model& model, Q | |||
| m_view->settings()->setAttribute(QWebEngineSettings::WebAttribute::LocalContentCanAccessRemoteUrls, true); | |||
| m_view->settings()->setAttribute(QWebEngineSettings::WebAttribute::SpatialNavigationEnabled, true); | |||
|
|
|||
| m_page = new OSWebEnginePage(this); | |||
| m_view->setPage(m_page); // note, view does not take ownership of page | |||
| m_page = new OSWebEnginePage(m_view); | |||
There was a problem hiding this comment.
Are you sure this change is needed?
| this->profile()->setUrlRequestInterceptor(interceptor); | ||
| } | ||
|
|
||
| OSWebEnginePage::~OSWebEnginePage() {} |
There was a problem hiding this comment.
I think you need to free the OSUrlRequestInterceptor*. You should perhaps just use a unique_ptr?
There was a problem hiding this comment.
https://doc.qt.io/qt-5/qwebengineprofile.html#setUrlRequestInterceptor
https://doc.qt.io/qt-5/qwebengineprofile.html#setUrlRequestInterceptor
I interpret that as meaning it doesn't free.
There was a problem hiding this comment.
welllll I guess you do pass this as a parent : OSUrlRequestInterceptor* interceptor = new OSUrlRequestInterceptor(this);...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.