Add benchmarking facilities to quantify performance of OSApp #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmarrec
commented
Apr 28, 2021
| @@ -243,6 +243,8 @@ option(BUILD_PACKAGE "Build package" OFF) | |||
|
|
|||
| option(BUILD_TESTING "Build testing" OFF) | |||
|
|
|||
| option(BUILD_BENCHMARK "Build benchmarking targets" OFF) | |||
Comment on lines
43
to
63
| static void BM_SpacesSurfaces(benchmark::State& state) { | ||
|
|
||
| openstudio::Application::instance().application(true); | ||
|
|
||
| model::Model model = makeModelWithNSurfaces(state.range(0)); | ||
|
|
||
| // Code inside this loop is measured repeatedly | ||
| for (auto _ : state) { | ||
| auto gridView = std::make_shared<SpacesSurfacesGridView>(false, model); | ||
| openstudio::Application::instance().application(true)->processEvents(); | ||
| benchmark::DoNotOptimize(gridView); | ||
| }; | ||
|
|
||
| state.SetComplexityN(state.range(0)); | ||
|
|
||
| } | ||
|
|
||
| // This doesn't work, it goes [6, 8, 16...] | ||
| //BENCHMARK(BM_SpacesSurfaces)->RangeMultiplier(2)->Range(6, 6<<6)->Unit(benchmark::kMillisecond)->Complexity(); | ||
| BENCHMARK(BM_SpacesSurfaces)->Arg(6)->Arg(12)->Arg(24)->Arg(48)->Arg(96)->Arg(192)->Arg(384)->Arg(768) // ->Arg(1536) // 1536 takes 89 secodns AFTER dan's improvements | ||
| ->Unit(benchmark::kMillisecond)->Complexity(); |
There was a problem hiding this comment.
Actual parametric benchmark, with complexity calculation.
Note: In this case I'm trying to compare two very different branches, so I couldn't really do two static void BM_xxx functions to compare in the same, so there's just the one
… it out later ``` qt.qpa.plugin: Could not load the Qt platform plugin "xcb" in "" even though it was found. This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem. ```
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to set up some benchmarking code for the past day, so we have something in place to:
I think I finally spat something that works
I am benchmarking the creation of the "Spaces > Surfaces" subtab, since this is a source of major slow down since you logically have way more surfaces than spaces (A rectangular space has 6...).
Here's a visualization that shows the current develop against #318