Replace deprecated set-env with $GITHUB_ENV #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….yml which is more up to date. Should be put into its own reusable file probably.
jmarrec
approved these changes
Oct 24, 2020
.github/workflows/app_build.yml
Outdated
| @@ -138,23 +139,23 @@ jobs: | |||
| sdk_version = '' | |||
| if m_major: | |||
| sdk_version += m_major.groups()[0] | |||
| print("::set-env name=OS_SDK_VERSION_MAJOR::{}".format(m_major.groups()[0])) | |||
| os.system(f"echo OS_SDK_VERSION_MAJOR={m_major.groups()[0]} >> $GITHUB_ENV") | |||
There was a problem hiding this comment.
That works probably. I've used it differently in python
OpenStudioApplication/.github/workflows/export_standards_data.yml
Lines 50 to 51 in e95d68c
There was a problem hiding this comment.
I'll bring that over from export_standards_data.yml which is more up to date on that front. We should put that code into its own reusable library file or something at one point, but no rush.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.