Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply to selected does not work on ThermalZone Cooling or Heating Size Parameters #476

Closed
macumber opened this issue Dec 16, 2021 · 2 comments · Fixed by #516
Closed

Apply to selected does not work on ThermalZone Cooling or Heating Size Parameters #476

macumber opened this issue Dec 16, 2021 · 2 comments · Fixed by #516

Comments

@macumber
Copy link
Collaborator

macumber commented Dec 16, 2021

Issue overview

Changes are applied but do not update until changing tabs. Likely need to add additional objects to watch on this tab

@macumber macumber added Triage Issue needs to be assessed and labeled, further information on reported might be needed severity - Normal Bug 🐛 and removed Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Dec 16, 2021
@macumber macumber added this to the OpenStudio Application 1.3.1 milestone Dec 16, 2021
@jmarrec
Copy link
Collaborator

jmarrec commented May 3, 2022

I've investigated this one a bit. On the TZ tab, the "Multiplier" works, but the stuff on the Cooling/Heating Sizing doesn't.

The main difference is that the Multiplier is a ValueEdit concept, while the non working ones are QuantityEdit, and work through a ProxyAdapter (because you actually set that stuff onto the ThermalZone's SizingZone object).

Fixing it is far from trivial, as it requires delving deep into the (way too large amount of and complicated aspect of) clever templates we have. I don't know how to fix it myself.

@jmarrec
Copy link
Collaborator

jmarrec commented May 4, 2022

I think I got a way, but it involves a nano_emit()...

@jmarrec jmarrec assigned jmarrec and unassigned j-lorrey May 4, 2022
jmarrec added a commit that referenced this issue May 4, 2022
jmarrec added a commit that referenced this issue May 4, 2022
…ne_ApplyToSelected

Fix #476 - Apply to selected does not work on ThermalZone Cooling or Heating Size Parameters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment