-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenStudio Standards Library OSMs #232
Comments
Based off of export_openstudio_libraries in openstudio-standards |
@macumber FYI last time I ran that os-standardsscript (2 years ago almost exactly), I made it parallel. It still took 19 hours to finish, on a 8 core 16 threads machine, and about 1/4 or 1/3 of the library files didn't successfully generate. OpenStudio hadn't done the update since then, we just had version translation-ed these files from release to release. Cf history on the 2.9.X-LTS branch: https://github.com/NREL/OpenStudio/commits/2.9.X-LTS/openstudiocore/src/openstudio_app/Resources/90_1_2004.osm In 1038789 I added a github actions that will run for PRs to master (which we should do to prepare for each release), and throw if the OSMs don't match the expected OpenStudio SDK version. |
Yeah that is a good idea to add that check on merge to master. Are you just suggesting that we run that script and start it sooner rather than later? If you have a script then I can run it. Or are you saying that there is no such script, we have to write it, and run it? I can probably do that too. |
Ok, I see, I got myself confused on my own issue. One approach is to simply version translate the existing files. The second (and better) approach is to re-export the files from current standards. I don't think the HVAC library can be exported from the standards, is that right? That is a hand maintained file? |
There are two files:
The HVAC Library is a hand maintained file. And if you were to add new objects to it before the IO Freeze / VT is complete, you should prepare a diff file or ruby script to add the new object, instead of VT'ing the entire library, or you could end up in a broken state later. |
Enhancement Request
OpenStudio Application ships with a library of standards OSM files. We want to keep these up to date with OpenStudio Standards.
Possible Implementation
Want a script that can be run to update these
Orthogonal to: #124
The text was updated successfully, but these errors were encountered: