Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenStudio Standards Library OSMs #232

Closed
macumber opened this issue Sep 12, 2020 · 6 comments
Closed

Update OpenStudio Standards Library OSMs #232

macumber opened this issue Sep 12, 2020 · 6 comments
Assignees
Labels
Enhancement Request New feature or request good first issue Good for newcomers Hacktoberfest

Comments

@macumber
Copy link
Collaborator

Enhancement Request

OpenStudio Application ships with a library of standards OSM files. We want to keep these up to date with OpenStudio Standards.

Possible Implementation

Want a script that can be run to update these

Orthogonal to: #124

@macumber macumber added Enhancement Request New feature or request Triage Issue needs to be assessed and labeled, further information on reported might be needed labels Sep 12, 2020
@macumber macumber added this to the OpenStudio Application 1.1.0 milestone Sep 12, 2020
@macumber macumber removed the Triage Issue needs to be assessed and labeled, further information on reported might be needed label Sep 12, 2020
@macumber
Copy link
Collaborator Author

@jmarrec
Copy link
Collaborator

jmarrec commented Oct 6, 2020

@macumber FYI last time I ran that os-standardsscript (2 years ago almost exactly), I made it parallel.

It still took 19 hours to finish, on a 8 core 16 threads machine, and about 1/4 or 1/3 of the library files didn't successfully generate. OpenStudio hadn't done the update since then, we just had version translation-ed these files from release to release. Cf history on the 2.9.X-LTS branch: https://github.com/NREL/OpenStudio/commits/2.9.X-LTS/openstudiocore/src/openstudio_app/Resources/90_1_2004.osm

In 1038789 I added a github actions that will run for PRs to master (which we should do to prepare for each release), and throw if the OSMs don't match the expected OpenStudio SDK version.

@macumber
Copy link
Collaborator Author

macumber commented Oct 7, 2020

Yeah that is a good idea to add that check on merge to master. Are you just suggesting that we run that script and start it sooner rather than later? If you have a script then I can run it.

Or are you saying that there is no such script, we have to write it, and run it? I can probably do that too.

@macumber
Copy link
Collaborator Author

macumber commented Oct 7, 2020

Ok, I see, I got myself confused on my own issue. One approach is to simply version translate the existing files. The second (and better) approach is to re-export the files from current standards.

I don't think the HVAC library can be exported from the standards, is that right? That is a hand maintained file?

@jmarrec
Copy link
Collaborator

jmarrec commented Oct 7, 2020

There are two files:

The HVAC Library is a hand maintained file. And if you were to add new objects to it before the IO Freeze / VT is complete, you should prepare a diff file or ruby script to add the new object, instead of VT'ing the entire library, or you could end up in a broken state later.

@jmarrec
Copy link
Collaborator

jmarrec commented Feb 4, 2021

@jmarrec jmarrec closed this as completed Feb 4, 2021
@jmarrec jmarrec self-assigned this Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Request New feature or request good first issue Good for newcomers Hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants