Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mild rejig of the browse pages #487

Closed
wants to merge 28 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
bbf5561
browse page: improve css for h4 headings
danstowell Sep 18, 2013
7371ae9
browse page: collect "download xml" & "edit" links w other right-hand…
danstowell Sep 19, 2013
7dc49f3
browse page: collapse "last edited" info rows into a sentence under t…
danstowell Sep 19, 2013
47f7afe
browse page: float browse-nav to right-hand side
danstowell Sep 19, 2013
c2d2b09
browse page: less wordy headers for changeset content panes
danstowell Sep 19, 2013
bebdbae
browse page: express last-edited time as user-friendly "time ago"
danstowell Sep 19, 2013
93fe5a2
browse page: undo my mistaken reordering of divs
danstowell Sep 21, 2013
c881ef4
browse page: no top-border-bar for first child needed now
danstowell Sep 21, 2013
63e1e77
browse page: better way of specifying "time ago" (for i18n)
danstowell Sep 21, 2013
cd8b516
browse page: more approachable headings
danstowell Sep 21, 2013
2da012d
browse page: ensure neat render (no spurious top bar) when no-tags-no…
danstowell Sep 21, 2013
ae5bdb2
browse page: formatting tweaks for small-screen mode
danstowell Sep 22, 2013
43b3f8a
browse page: printable_name() opt args converted to named hash options
danstowell Sep 28, 2013
6c48876
browse page: full rather than "lego" i18n strings for editsummary
danstowell Sep 28, 2013
64b98e0
browse page: reinstate version metadata on history page
danstowell Sep 28, 2013
45a056f
browse page: remove title translations that are now no-op
danstowell Sep 28, 2013
d0b8718
bugfix: remove superfluous bracket in css
danstowell Oct 8, 2013
6e18e76
browse pages: use common "pager" style across large and small
danstowell Oct 8, 2013
83d787a
browse page: improve line-wrapping of the new edit summary
danstowell Oct 8, 2013
f091f75
update locales to remove three browse.*.*_title keys no longer used
danstowell Oct 8, 2013
ca98e8d
fix previous linebreak commit so it looks good on the history pages too
danstowell Oct 8, 2013
8348c4e
browse page: don't show edit summary stats if redacted
danstowell Oct 8, 2013
3af7c2a
browse page: update tests for redactions
danstowell Oct 8, 2013
b94c1c7
browse page: move changeset's when+who info into heading, matching th…
danstowell Oct 27, 2013
471bc62
browse page: fix misaligned "Comment" heading
danstowell Oct 28, 2013
2e043a3
browse page: historylink inside versioninchangeset (not working for h…
danstowell Nov 3, 2013
19469ed
browse page: history link in version text
danstowell Nov 3, 2013
a634f12
browse page: "View history" title for version link
danstowell Nov 4, 2013
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
browse page: undo my mistaken reordering of divs
(fixes a clear:both issue on small screens)
danstowell committed Sep 21, 2013

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 93fe5a28e12b8aaeefd6a577e9a05e083e0d1382
12 changes: 6 additions & 6 deletions app/views/browse/_common_details.html.erb
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<% if common_details.changeset.tags['comment'].present? %>
<div class='browse-section common'>
<div>
<div class='browse-section common'>
<div>
<%= render :partial => "tag_details", :object => common_details %>
<% if common_details.changeset.tags['comment'].present? %>
<h4><%= t 'browse.common_details.changeset_comment' %></h4>
<p><%= linkify(h(common_details.changeset.tags['comment'])) %></p>
</div>
<% end %>
</div>
<% end %>
<%= render :partial => "tag_details", :object => common_details %>
</div>