W3C Geolocation added to user account settings page (4rd attempt) #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -112,7 +112,8 @@ | |||
| <tr> | |||
| <td></td> | |||
| <td> | |||
| <p><%= t 'user.account.update home location on click' %> <input type="checkbox" value="1" <% unless @user.home_lat and @user.home_lon %> checked="checked" <% end %> id="updatehome" /> </p> | |||
| <p><%= t 'user.account.update home location on click' %> <input type="checkbox" value="1" <% unless @user.home_lat and @user.home_lon %> checked="checked" <% end %> id="updatehome" /> | |||
| <% if @user.home_lat and @user.home_lon %><span align=right><a href="#map" onClick=locate_user()>center map on my current position</a></span><% end %></p> | |||
There was a problem hiding this comment.
I suggest using the link_to_function rails helper here instead of creating the link yourself, and the text of the link needs to be translatable - use t("user.account...") and add the string to config/locales/en.yml.
Closed
|
The redesign work (#498) which has just been merged has added geolocation support to the user settings page. |
danstowell
pushed a commit
to danstowell/openstreetmap-website
that referenced
this pull request
Jan 26, 2015
…ebox Use 'close-box' appearance (less confusing) for exit-from-directions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added W3C Geolocation functionality to the user location map on the account settings page. This attempts to find a coarse location if the user has no home location set, so as to make setting the home location easier. If the location is already set, the map can be manually centered on the approx location by clicking a link on top of the map. When W3C geolocation fails (or is denied by the user), the page falls back to the old behaviour of showing a world map.