-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add maxweight to helipad preset #1234
Conversation
🍱 You can preview the tagging presets of this pull request here. |
When we get around to implementing a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testcase:
- https://overpass-turbo.eu/s/1M0M
- https://pr-1234--ideditor-presets-preview.netlify.app/id/dist/#background=Bing&disable_features=boundaries&id=w26444075&locale=en&map=19.73/52.50830/13.36018
Right now this shows as a dropdown field. Is that the best option we have ATM? Do we want to keep the dropdown options?
I'll let someone else answer this, it's been like that for a long time. Not sure if anyone finds the suggestions useful... |
Yes, makes sense to keep it like it was. At the very least the suggestions are an indicator on how to format the values. And once ideditor/schema-builder#15 lands this will be improved anyway. |
Thanks for the addition. I just merged this and added Minh's comment in ideditor/schema-builder#15 (comment) so we don't forget. |
the
maxweight
of a helipad is often stenciled into the ground in huge block letters, so it's easy to map from aerial imagery.The preset would benefit from having the
maxweight
field.