Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make denomination field translatable #254

Open
matkoniecz opened this issue Oct 21, 2021 · 5 comments
Open

Make denomination field translatable #254

matkoniecz opened this issue Oct 21, 2021 · 5 comments
Labels
new-field translations this is an issue with a translation, which needs to be solved on the transifex platform

Comments

@matkoniecz
Copy link
Contributor

It would be useful to provide translations for non-English speakers

@1ec5
Copy link
Contributor

1ec5 commented Nov 4, 2021

Should we split up the Denomination field into multiple fields, one per religion? That would allow us to filter out irrelevant values, which would be a significant usability improvement. On the other hand, the list of denominations for some religions is rather open-ended, and the less common denominations are the ones that benefit the most from a taginfo-based list.

@matkoniecz
Copy link
Contributor Author

Should we split up the Denomination field into multiple fields, one per religion? That would allow us to filter out irrelevant values, which would be a significant usability improvement.

That would be also very useful for some other data consumers. For example in streetcomplete/StreetComplete#1737 I would be able to limit to list of Christian denomination/rites/churches without maintaining own list which denomination values are Christian.

On the other hand, the list of denominations for some religions is rather open-ended, and the less common denominations are the ones that benefit the most from a taginfo-based list.

Is it possible to show Christian denominations/rites/churches and then taginfo values which exclude known Muslim/etc denominations?

And for mosques show Muslim denominations/variants and then taginfo values which exclude Christian/etc denominations?

Even just showing all denominations specific to given religion and then all taginfo values would be significant usability improvement.

@1ec5
Copy link
Contributor

1ec5 commented Jan 2, 2022

Is it possible to show Christian denominations/rites/churches and then taginfo values which exclude known Muslim/etc denominations?

And for mosques show Muslim denominations/variants and then taginfo values which exclude Christian/etc denominations?

Not really, because the relationships between the religions and denominations isn’t defined anywhere in the tagging system. Only Wikidata has that information in machine-readable format.

We could start to curate denominations by creating a separate denomination field for each religion. Each field would have type set to combo and autoSuggestions set to false. Users would still be able to enter unlisted values, as long as customValues remains false, but we’d have to keep an eye on the most popular denomination values to make sure they’re getting surfaced in the dropdown as localizable suggestions.

@matkoniecz
Copy link
Contributor Author

Not really, because the relationships between the religions and denominations isn’t defined anywhere in the tagging system. Only Wikidata has that information in machine-readable format.

To clarify: I was proposing to start recording this info in this preset.

And OSM Wiki has already this classification for at least more popular ones

@tyrasd tyrasd added translations this is an issue with a translation, which needs to be solved on the transifex platform new-field labels Jan 7, 2022
@tyrasd
Copy link
Member

tyrasd commented Jan 7, 2022

Users would still be able to enter unlisted values, as long as customValues remains false

you mean as long as customValues remains true, right? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-field translations this is an issue with a translation, which needs to be solved on the transifex platform
Projects
None yet
Development

No branches or pull requests

3 participants