Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix esbuild ignoring browserslist config #9934

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

k-yle
Copy link
Collaborator

@k-yle k-yle commented Oct 7, 2023

Closes #9930, Closes #9939

esbuild targets esnext by default, so new syntax like ??= isn't being transpiled. This means iD only supports the very latest browsers.

There is a browserslist config in package.json, but esbuild doesn't respect the browserslist by default, unlike the previous build system.

With these polyfills, the bundle size has increased by less than 0.1%

Verified

This commit was signed with the committer’s verified signature.
k-yle Kyℓe Hensel
@nickrsan nickrsan added the priority A top priority issue that has a big impact or matter most to new mappers label Oct 10, 2023
@tyrasd tyrasd added the chore-build Improvements to the iD build scripts / CI environment label Nov 8, 2023
@tyrasd tyrasd merged commit dc5bad3 into openstreetmap:develop Nov 8, 2023
@k-yle k-yle deleted the browserlist branch November 8, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-build Improvements to the iD build scripts / CI environment priority A top priority issue that has a big impact or matter most to new mappers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

does not work with Firefox 78.15.0esr any more
3 participants