Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug with space #3717

Merged
merged 1 commit into from
Jan 5, 2017
Merged

fix a bug with space #3717

merged 1 commit into from
Jan 5, 2017

Conversation

miladkdz
Copy link
Contributor

@miladkdz miladkdz commented Jan 4, 2017

Along with the recent changes in #3707, found a bug with various cases when the string contains a space. So wrote a quick fix for it.

@bhousel
Copy link
Member

bhousel commented Jan 4, 2017

I see the additions of || nextCode === 32

Should we maybe do /\s/.test(String.fromCharCode(nextCode)) to catch any kind of whitespace (tabs, spaces, etc)?

@miladkdz
Copy link
Contributor Author

miladkdz commented Jan 5, 2017

Are we supposed to support Tabs? Regex test might be much more expensive here.

@bhousel bhousel merged commit 4729bbb into openstreetmap:master Jan 5, 2017
@bhousel
Copy link
Member

bhousel commented Jan 5, 2017

Are we supposed to support Tabs? Regex test might be much more expensive here.

I'm not sure whether it matters, so I'll merge it as-is and we can reticket later if there are issues with other whitespace characters.. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants