Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust coworking preset #3714

Merged
merged 2 commits into from
Jan 3, 2017
Merged

Adjust coworking preset #3714

merged 2 commits into from
Jan 3, 2017

Conversation

iandees
Copy link
Collaborator

@iandees iandees commented Jan 3, 2017

Move the amenity=coworking_space preset to a more sensible office=coworking.

From the Department Of Not Everything's An Amenity.

@bhousel
Copy link
Member

bhousel commented Jan 3, 2017

SGTM, thanks @iandees 👍

@bhousel bhousel merged commit 3989e45 into openstreetmap:master Jan 3, 2017
@abdeldjalil09
Copy link
Contributor

office=coworking is undocumented tag

@pnorman
Copy link
Contributor

pnorman commented Jan 3, 2017

office=coworking is undocumented tag

With 34 uses vs the 500ish for amenity=coworking_space

@talllguy
Copy link

talllguy commented Jan 3, 2017

This doesn't qualify as documentation?

@polarbearing
Copy link

@talllguy, not sure what your 'This' refers to. Anyway it is good practice to at least discuss tagging changes on the mailing list, which has started yesterday.

@tuxayo
Copy link

tuxayo commented Mar 25, 2017

I agree that office=coworking is better and that not everything should be an amenity.

But why is it a good idea to make iD switch the preset from amenity to office when the wiki have not?

Discussion about changing the tag on the wiki: https://wiki.openstreetmap.org/wiki/Talk:Tag:amenity%3Dcoworking_space

@bhousel
Copy link
Member

bhousel commented Mar 26, 2017

But why is it a good idea to make iD switch the preset from amenity to office when the wiki have not?

The last time I looked, the wiki had been changed over and people were using the new tag, but I guess someone changed the wiki back?

To be honest, if a tag has only like 500 uses, I don't care too much. Anyone who knows overpass and JOSM and has an hour of free time can just update the tag to whatever they want, right? It seems like everyone agrees office=coworking is better, so.. why not just change it?

@polarbearing
Copy link

The last time I looked, the wiki had been changed over and people were using the new tag, but I guess someone changed the wiki back?

Not sure when you looked. However when this issue started here, somebody had moved the wiki page form amenity= to office= which is against the policy that the wiki documents how a tag is used, not vice versa. Thus the move was reverted after discussion on the tagging list, and the office page currently redirects to the amenity. Please note that there might be coworking spaces currently tagged that are not offices. Of course the page office=coworking can be filled with documentation of this tag.

To be honest, if a tag has only like 500 uses, I don't care too much. Anyone who knows overpass and JOSM and has an hour of free time can just update the tag to whatever they want, right? It seems like everyone agrees office=coworking is better, so.. why not just change it?

You are proposing an Automated Edit which is only allowed in special cases, read here why. Migrating a tag is not such a case, thus please don't encourage a mechanical edit here. As said above, there might be places that are not offices, thus each place needs to be reviewed with local knowledge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants