Japanese address scheme #3712
Closed
Japanese address scheme #3712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, it looks ok, as far as I can tell.. I did notice something strange going on with address field combo boxes - it seems like d3 isn't always removing them. I'll dig into this today and try to find out what's happening. (It's not an issue with the code you added. I think it's an existing bug in the address field we didn't see before).
|
|
The weird field formatting has something to do with Helvetica Neue's handling of kanji glyphs. I don't understand the root cause, but I'm following some of the guidance here to use modern system fonts, which are all better than Helvetica Neue these days. Most people probably will not notice the difference, but the new fontstack looks a little nicer.. |
|
This was merged |
This was referenced Jan 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a temporary Japanese address scheme. Still country-specific placeholders should be defined, look at #3643.