Add Taiwan phone format #3655
Closed
Add Taiwan phone format #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is "+886 2 2720 8889" an example number or somebody's actual phone number? I'd expect an example number to look like "+886 123456789". This format looks a bit different from what Wikipedia suggests. |
bhousel
suggested changes
Dec 16, 2016
| @@ -49,6 +49,7 @@ | |||
| "ru": "+7 495 1234567", | |||
| "kz": "+7 495 1234567", | |||
| "vn": "+84 1 234 5678", | |||
| "hk": "+852 12345678" | |||
| "hk": "+852 12345678", | |||
| "tw": "+886 2 2720 8889", | |||
There was a problem hiding this comment.
I get a parse error because of this trailing comma, can you remove it?
|
Sure, I'll fix it. |
|
Wow, I didn't notice it use fake number, I've just pick the phone number from Taipei City Government. Thanks for transformation of fake number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.