Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route relation member sorting #7498

Open
tomasokol opened this issue Apr 2, 2020 · 2 comments
Open

Route relation member sorting #7498

tomasokol opened this issue Apr 2, 2020 · 2 comments
Labels
enhancement An enhancement to make an existing feature even better

Comments

@tomasokol
Copy link

Hi,
as Wiki says, a Bus route should have relation members in this order:

  1. bus stops (in the direction the bus is going)
  2. roads (in the direction of the bus)

So iD should keep bus stops at the top of the list. That should be relatively easy, i suppose.
Options are:

  1. still just one “window” for all members;
  2. splitting the existing “window” into two, one containing stops, the other containing roads.

It would be really nice to have the stops ordered automatically by the iD. If it could analyze the route and sort the bus stops that sit along. And again, two options:

  1. supporting all types of mapping (the simple one, with just public_transport=platform beside the road;
  2. supporting only routes that are mapped by public_transport=platform along with public_transport=stop_position.

Also, there is a name for route=bus “Bus Route.” But there is none for “route=trolleybus,” as it is just a “Route” in iD.

quincylvania added a commit that referenced this issue Apr 3, 2020
Add Trolleybus Route preset (re: #7498)
Remove Level field from Stop Position presets (close #7499)
Add Stop Number field to transit platform-as-point presets (close #7492)
Add Distance and Color fields to more route presets
Use field inheritance for several more route presets
@quincylvania
Copy link
Collaborator

Also, there is a name for route=bus “Bus Route.” But there is none for “route=trolleybus,” as it is just a “Route” in iD.

Okay, I added a Trolleybus Route preset.

It would be really nice to have the stops ordered automatically by the iD.

iD could definitely be smarter about placing new members when adding them to route relations. But I'm not sure if it should be reordering existing members or not.

@quincylvania quincylvania added the enhancement An enhancement to make an existing feature even better label Apr 3, 2020
@tomasokol
Copy link
Author

tomasokol commented Apr 10, 2020

But I'm not sure if it should be reordering existing members or not.

Validator could suggest, that lines are not in order (there is a gap / members are not in the right order). If it should be automatically sorted, I don't know.

Though it could be automatically putting all the stops and stopping positions above lines/roads, in the list. I don't see any situation when somebody would not want that to happen or wanted to keep it sorted differently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement to make an existing feature even better
Projects
None yet
Development

No branches or pull requests

2 participants