Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably wrong display of the surface tag on roads #7466

Closed
mfbehrens opened this issue Mar 26, 2020 · 5 comments
Closed

Probably wrong display of the surface tag on roads #7466

mfbehrens opened this issue Mar 26, 2020 · 5 comments
Assignees
Labels
map-renderer An issue with how things are rendered in the map
Milestone

Comments

@mfbehrens
Copy link

Hello,

I just added the surface tag to a living street and the street changed its style to the unpaved road look.
Is this correct or is this a bug?

Michael

@quincylvania
Copy link
Collaborator

quincylvania commented Mar 26, 2020

@mfbehrens99 What surface value did you use? iD uses a narrow definition of "paved" which is more about smooth vs. bumpy. All values except these get the "unpaved" styling:

iD/modules/osm/tags.js

Lines 120 to 131 in 5125c04

export var osmPavedTags = {
'surface': {
'paved': true,
'asphalt': true,
'concrete': true,
'concrete:lanes': true,
'concrete:plates': true
},
'tracktype': {
'grade1': true
}
};

@quincylvania quincylvania added map-renderer An issue with how things are rendered in the map waitfor-info Waiting for more info labels Mar 26, 2020
@mfbehrens
Copy link
Author

I mean this surface:
wiki.openstreetmap.org/wiki/Key:surface

The way I mean is this here:
openstreetmap.org/edit#map=21/50.00002/8.23741
openstreetmap.org/way/390473400

@quincylvania
Copy link
Collaborator

It looks like the tag in question is surface=paving_stones? This has come up before in #6691. The rationale is that most highways are considered have an asphalt-like surface by default in OSM, so it's helpful to style anything else differently.

However, it's true there's a real difference between paving stones and dirt. Perhaps we can consider a third style for intermediate-level pavement.

@quincylvania quincylvania removed the waitfor-info Waiting for more info label Mar 26, 2020
@mfbehrens
Copy link
Author

But is paving stones not asphalt-like as well? After some rain there is no problem with mud or things like that. Same for the smoothness.

@quincylvania
Copy link
Collaborator

quincylvania commented Mar 27, 2020

Perhaps we can consider a third style for intermediate-level pavement.

I did this ☝️. I went with a subtle dash with the paved casing color that is meant to convey "not quite asphalt" while still being considerably better than earth or gravel.

Screen Shot 2020-03-26 at 7 21 47 PM


But is paving stones not asphalt-like as well?

This definition no-doubt varies by culture. Here in the US, paving stones are extremely uncommon for public streets. Where they do exist, they vary considerably in smoothness quality. Thus, they're mentally distinct from what we'd typically think of as a paved road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map-renderer An issue with how things are rendered in the map
Projects
None yet
Development

No branches or pull requests

2 participants