Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Add a bridge" suggestion missing if stream is selected #7447

Closed
jidanni opened this issue Mar 23, 2020 · 5 comments
Closed

"Add a bridge" suggestion missing if stream is selected #7447

jidanni opened this issue Mar 23, 2020 · 5 comments
Labels
validation An issue with the validation or Q/A code wontfix-not-a-bug Not actually a bug
Milestone

Comments

@jidanni
Copy link
Contributor

jidanni commented Mar 23, 2020

Here we see the user will miss the very important option to "Add a bridge", depending on which of the two items is selelcted.
27485-1
7498-0

@maro-21
Copy link

maro-21 commented Mar 23, 2020

As you can see it creates a tunnel or bridge on the selected feature.
It's because a stream can be in a tunnel but not on a bridge...
A road can be on a bridge but... Why tunnel is here? I don't think there are roads under a ditch ;). Even if there are, this is very rare case so this option shouldn't be here.
So there is no missing "add a bridge" but rather "add a tunnel" should be removed.

To not open a new issue:
I would like to suggest reorder "Connect using a ford" and "Add a tunnel" to the following order:

  1. Add a tunnel - because this is the most common case. Ditches/streams are usually under the road
  2. Connect using a ford - this one shouldn't be on the first position. Before renaming this field from "Connect" to "Connect using a ford" many people using iD connected streams with roads and created many non-existent fords.

@quincylvania quincylvania added the validation An issue with the validation or Q/A code label Mar 23, 2020
@quincylvania
Copy link
Collaborator

It's because a stream can be in a tunnel but not on a bridge...

Right. Aqueducts are possible in OSM but uncommon.

A road can be on a bridge but... Why tunnel is here? I don't think there are roads under a ditch ;).

Huh, I hadn't thought about this before but it's a good point. Tunnels under waterways are also fairly uncommon.

Connect using a ford - this one shouldn't be on the first position

Maybe. There are many types of crossing issues where connecting is the desired solution, e.g. road/path, and it's nice to keep the order consistent.

To not open a new issue

It's okay to open a separate issue if the concern is different than the original post.

@jidanni
Copy link
Contributor Author

jidanni commented Mar 24, 2020

All I know is when uploading an edit with nearby missing tunnel/bridges, we get warnings. It seems to always give us the stream's warning instead of the road's warning.

This is too bad, because where I live these all should be fixed with bridges, not tunnels.
(Bridges are cheaper for municipalities than tunnels.)

So I must remember to click the road, to get the bridge solution suggestion.

@quincylvania
Copy link
Collaborator

All I know is when uploading an edit with nearby missing tunnel/bridges, we get warnings. It seems to always give us the stream's warning instead of the road's warning.

Ah okay, you're trying to add a road bridge instead of a stream tunnel, not a road tunnel.

An issue like this is shared by multiple features but the fixes are specific to the selection. When clicking an issue in the issues list, one of the features is arbitrarily selected. #5897 would make it possible to choose which feature to select.

@jidanni
Copy link
Contributor Author

jidanni commented Mar 24, 2020

Well all I know is the warning system should say
"A stream crosses a road.
Add a bridge?
Add a tunnel?
Add a ford?" etc.

The average user is not going to double check which of the two items iD has arbitrarily selected, and hence will always miss out on some valid solution options. (And like me, create lots of tunnels thinking it was the only proper choice!)

Therefore iD should always present all possible solutions. Perhaps in two lists if necessary, all shown on the same screen. (But merged into one list is better.)

So the "Add a bridge" choice would select the road, and add the bridge.
And the "Add a tunnel" choice would select the stream, and add a tunnel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation An issue with the validation or Q/A code wontfix-not-a-bug Not actually a bug
Projects
None yet
Development

No branches or pull requests

3 participants