Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging lines with certain relations should be warned/forbidden #3825

Closed
afmenez opened this issue Feb 6, 2017 · 2 comments · Fixed by #8675
Closed

Merging lines with certain relations should be warned/forbidden #3825

afmenez opened this issue Feb 6, 2017 · 2 comments · Fixed by #8675
Labels
bug A bug - let's fix this!

Comments

@afmenez
Copy link

afmenez commented Feb 6, 2017

When merging lines (roads, rivers) with differing relations of some types (borders!), the user should be at least warned of the change.

@afmenez afmenez changed the title Merging lines with certain relation should be warned Merging lines with certain relations should be warned ir forbidden Feb 6, 2017
@bhousel
Copy link
Member

bhousel commented Feb 6, 2017

When merging lines (roads, rivers) with differing relations of some types (borders!), the user should be at least warned of the change.

Can you give an example? I thought that iD already prevents merging lines in some cases because they belong to relations.

@afmenez
Copy link
Author

afmenez commented Feb 6, 2017

Sure. Let's say a have a city limit that coincides with a river (like this one: http://www.openstreetmap.org/way/472662123). In this case, only the river is shown on the editor interface (even when the line is selected you have to scroll way down to see that there's a relation attached to the river). You can then shift select an adjacent section of the river (like this one http://www.openstreetmap.org/way/472662128) and merge them. This should't be possible, or at least a warning should be given before the merge.

@bhousel bhousel added the bug A bug - let's fix this! label Feb 6, 2017
@afmenez afmenez changed the title Merging lines with certain relations should be warned ir forbidden Merging lines with certain relations should be warned/forbidden Feb 8, 2017
jfirebaugh added a commit that referenced this issue Sep 4, 2021
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
jfirebaugh added a commit that referenced this issue Sep 4, 2021
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
jfirebaugh added a commit that referenced this issue Sep 4, 2021
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
jfirebaugh added a commit that referenced this issue Sep 4, 2021
The operation is disabled when attempting to join ways which don't belong to identical sets of relations. Restriction relations are excluded, because they are already handled with slightly different logic.

Fixes #8674
Fixes #8645
Fixes #3825
Fixes #1512
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug - let's fix this!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants