Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support maki2 #3024

Closed
bhousel opened this issue Mar 9, 2016 · 5 comments
Closed

Support maki2 #3024

bhousel opened this issue Mar 9, 2016 · 5 comments
Assignees
Labels
chore-dependency Improvements to one of iD's dependencies core An issue with one of the core iD components

Comments

@bhousel
Copy link
Member

bhousel commented Mar 9, 2016

This is just a placeholder issue to keep an eye on
https://github.com/mapbox/maki-2/issues/46
Maki2 will likely be merged into Maki, which will get a major semver bump.

^UPDATE: this happened already, see mapbox/maki#241

This is good!

iD is currently pinned to Maki 0.5.0, so we don't need to do anything right away.

We might be able to install both versions, and build 2 spritesheets so that we don't lose any of the Maki1 icons that aren't yet available in Maki2.

@bhousel bhousel added the waitfor-upstream Waiting for something in an upstream project label Mar 9, 2016
@bhousel
Copy link
Member Author

bhousel commented May 24, 2016

related ticket in Maki: mapbox/maki#270

@pnorman
Copy link
Contributor

pnorman commented May 25, 2016

@bhousel
Copy link
Member Author

bhousel commented May 25, 2016

Thanks @pnorman I updated the issue.
maki2 repo is gone and its contents got folded into the main maki repo.
see mapbox/maki#241

@bhousel bhousel changed the title Deal with whatever maki is doing Support maki2 Jul 19, 2016
@bhousel bhousel added chore-dependency Improvements to one of iD's dependencies core An issue with one of the core iD components and removed waitfor-upstream Waiting for something in an upstream project labels Nov 1, 2016
@nickidlugash
Copy link

@bhousel I just wanted to flag that Maki 2 icons are different sizes than Maki 1: they are 11px/15x versus 12px/18px/24px. It looks like you're currently using Maki 1 -24 for the UI, resized to 32px, and Maki 1 at actual size for the map? Will it work for your purposes to use both versions at the same time?

/cc @natslaughter @aparlato

@bhousel
Copy link
Member Author

bhousel commented Dec 12, 2016

Will it work for your purposes to use both versions at the same time?

It would probably be ok, but we'll need to add some code to store what icon sizes are available and have iD pick the best size. See #3025 for more info

@bhousel bhousel added the wip Work in progress label Jan 12, 2017
@bhousel bhousel removed the wip Work in progress label Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore-dependency Improvements to one of iD's dependencies core An issue with one of the core iD components
Projects
None yet
Development

No branches or pull requests

4 participants