-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support maki2 #3024
Comments
related ticket in Maki: mapbox/maki#270 |
Thanks @pnorman I updated the issue. |
@bhousel I just wanted to flag that Maki 2 icons are different sizes than Maki 1: they are 11px/15x versus 12px/18px/24px. It looks like you're currently using Maki 1 |
It would probably be ok, but we'll need to add some code to store what icon sizes are available and have iD pick the best size. See #3025 for more info |
This is just a placeholder issue to keep an eye on
https://github.com/mapbox/maki-2/issues/46Maki2 will likely be merged into Maki, which will get a major semver bump.^UPDATE: this happened already, see mapbox/maki#241
This is good!
iD is currently pinned to Maki 0.5.0, so we don't need to do anything right away.
We might be able to install both versions, and build 2 spritesheets so that we don't lose any of the Maki1 icons that aren't yet available in Maki2.
The text was updated successfully, but these errors were encountered: