Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard list of paved tags #2847

Closed
pnorman opened this issue Nov 26, 2015 · 4 comments
Closed

Use standard list of paved tags #2847

pnorman opened this issue Nov 26, 2015 · 4 comments

Comments

@pnorman
Copy link
Contributor

pnorman commented Nov 26, 2015

Follow-up to #2564

iD currently has

iD.pavedTags = {
    'surface': {
        'paved': true,
        'asphalt': true,
        'concrete': true
    },
    'tracktype': {
        'grade1': true
    }
};

The standard wiki-derived list for the paved tag is is

CASE WHEN surface IN ('unpaved', 'compacted', 'dirt', 'earth', 'fine_gravel', 'grass', 
                      'grass_paver', 'gravel', 'ground', 'mud', 'pebblestone', 'salt',
                      'sand', 'woodchips', 'clay') THEN 'unpaved' ELSE 
CASE WHEN surface IN ('paved', 'asphalt', 'cobblestone', 'cobblestone:flattened', 'sett',
                      'concrete', 'concrete:lanes', 'concrete:plates', 'paving_stones',
                      'metal', 'wood') THEN 'paved' 
@bhousel
Copy link
Member

bhousel commented Nov 26, 2015

Really? Wood and cobblestones? Maybe in OHM that would be considered paved..

@pnorman
Copy link
Contributor Author

pnorman commented Nov 27, 2015

As discussed in the osm-carto, you can draw the distinction different ways for different purposes. If you're riding a bike, compacted is better than metal or the stone based options, if you've got a dirt bike, different options are okay, if you're concerned about washout, other options are okay, etc.

This is why we went with the list from the wiki

@bhousel
Copy link
Member

bhousel commented Dec 1, 2015

Ok, I guess we agree that whether or not a surface is "paved" is a subjective opinion.

My goal for rendering the surface tags in iD is to call attention to map features that might be mistagged.

The surface wiki page also says that "For roads for motor vehicles there there is normally an assumption that the surface is surface=paved unless otherwise stated."

This is helpful because in places like old city Philadelphia, the cobblestoned streets stand out because they have an interesting surface tag. I can look at this map and know right away that they are tagged correctly:

screenshot 2015-12-01 14 42 37

In Addis Ababa where gravel and unpaved streets are normal, this street stands out because it is missing a surface tag:

screenshot 2015-12-01 15 18 33

I recognize that it's an opinionated rendering, so what I've done in 0b93fef is now I'm including surface and tracktype as secondary tag classes. This means that anyone can override these defaults and make an iD that renders differently surfaced roads however they want to.

Given that the goal is to help people map surfaces correctly (not routing, not urban planning, etc) I'm going to close this issue - but I am totally open to evolving the paved/unpaved list if we get feedback from mappers about how helpful (or annoying) the "bumpy" unpaved style is.

@matkoniecz
Copy link
Contributor

Really? Wood

wood is the most commonly found on smaller footbridges/cyclebridges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants