Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with presets and tagging on closed ways drawn with line tool instead of area tool #1293

Closed
bussed opened this issue Apr 11, 2013 · 6 comments

Comments

@bussed
Copy link

bussed commented Apr 11, 2013

I draw a closed way using the line drawing tool (not area tool).

Now i want to tag it with "building=yes".

At first i try using the Building preset but it wont show up when i search for it. No chance.

So i fall back using the "Other" preset.
At the bottom in the inspector view i add the tag building=yes. But this tag is never applied. After reopening the inspector view the tag is lost.

So i end up that i cannot apply a building=yes on a closed way drawn with the line tool.

I do really like that users get a push using the area drawing tool instead of using the line drawing tool. But to have no chance to apply the tag at all is a bit too strict in my opinion.

@tmcw
Copy link
Contributor

tmcw commented Apr 11, 2013

I draw a closed way using the line drawing tool (not area tool). Now i want to tag it with "building=yes".

In short: why?

@bussed
Copy link
Author

bussed commented Apr 11, 2013

Because i can :-) and am used to it doing it that way and the geom is valid aswell.
The way implemented in iD is future proof if OSM gets an dedicated area type someday.
I could easily accept it if i had to apply the tags manually somewhere deep inside the inspector view.
But to have no chance to apply the tags at all leaves the mapper somewhat demotivated and leads to the decision to throw it either away or to upload untagged ways (both not desired).
I dont know of any other editor being that strict.
At least there should be a warning like "hey, you are trying to apply area tags to something drawn with the line tool. bla bla this is not cool bla bla... draw it instead with the area tool". Right now it does just throw it away saying nothing. It took me really some time to figure it out what is happening here.

I do really appreciate that you try to take a fresh approach in editing maps and dont just copy every bit of josm.

@tmcw
Copy link
Contributor

tmcw commented Apr 11, 2013

Also, in a quick test: if I add building=yes to a close line, the next time you click on the polygon, it's in the building preset, so the tag is not 'thrown away' but is integrated into the preset interface. Do you still see the Other preset or do you see the Building preset?

@jfirebaugh
Copy link
Member

At the bottom in the inspector view i add the tag building=yes. But this tag is never applied. After reopening the inspector view the tag is lost.

It isn't lost. The feature is now recognized as an area and the building=yes tag is shown in the preset field:

image

You may be interested in #1181 (Show all tags in 'Additional tags' area) or #1214.

@bussed
Copy link
Author

bussed commented Apr 11, 2013

Are those changes already live on openstreetmap.us?

I cant confirm it (tried with ff and safari)

  • i draw the closed way with the line tool. Hit ESC
  • select way. inspector pops up.
  • select preset "other"
  • add tag building=yes under additional tags
  • leave the inspector by clicking on the map
  • again selecting the way. --> no preset and no tag.

@jfirebaugh
Copy link
Member

#1295 is the underlying bug here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants