Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should you be able to tag a closed line with area presets? #1214

Closed
jfirebaugh opened this issue Mar 30, 2013 · 2 comments
Closed

should you be able to tag a closed line with area presets? #1214

jfirebaugh opened this issue Mar 30, 2013 · 2 comments
Labels
preset An issue with an OpenStreetMap preset or tag

Comments

@jfirebaugh
Copy link
Member

I just came on an existing untagged closed line surrounding a man_made=wastewater_plant. Clearly someone had forgotten to tag. But I couldn't apply the Wastewater Plant preset, because it's for points and areas, not lines.

Maybe it should be possible to search for and apply area presets to closed lines?

As a workaround, I added an area=yes tag and then reselected the way.

@Vanuan
Copy link
Contributor

Vanuan commented Apr 20, 2013

I've just run into this issue for the "power=sub_station" tag: http://wiki.openstreetmap.org/wiki/Tag:power%3Dsub_station
The wiki lists that it should be applied only to areas and points.

There are at least three problems I have:

  1. Closed paths are not areas, so when I click on a closed path mapped with tags "power=sub_station", "Substation" preset is not selected.
  2. When I add a feature with "area=yes", and then apply "Substation" preset, the "area" tag is deleted.
  3. When I add "building"="yes" tag, the "Building" preset is selected instead of the "Substation".

Maybe it is a problem with this specific preset, but maybe it is a more general one?

Here are my thoughts on possible solutions:

  1. I find it a rare situation when a closed path is not an area. Probably it is better to assume that closed path is area by default (with exceptional cases when it isn't) rather than assume that closed path is not an area (with exceptional cases when it is).
  2. Same as 1. But adding "area"="yes" automatically doesn't harm, I believe. Or does it?
  3. This is a hard one. What to do if multiple presets matches a specific tag combination?

For this specific case it it enough to add "building"="*" to the sub_station matching preset. But what about points? They don't have to have building to be matched. Does it mean there should be different matching/applied tags for points and areas? See #1338

@jfirebaugh
Copy link
Member Author

I think showing all the area presets for lines would cause more usability problems than it solves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preset An issue with an OpenStreetMap preset or tag
Projects
None yet
Development

No branches or pull requests

2 participants