Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error styling updates #58

Merged
merged 5 commits into from
Oct 24, 2024

Conversation

MReyna12
Copy link
Contributor

@MReyna12
Copy link
Contributor Author

Screenshot of what the error styled checkbox / message looks like checked:
Screenshot 2024-10-17 at 4 36 35 PM

The color scheme / style in the figma file didn't provide a checked error style. I opted for the red listed in the issue description (#C22032). Based on the issue history, I believe the checkbox will be in a disabled state once unchecked, so I think the unchecked styles found in the figma file no longer apply.

Additionally, I mirrored the pattern used for the Radio component in inputTypes.tsx in order to apply the different styles to the checkbox (for consistency).

@MReyna12 MReyna12 marked this pull request as ready for review October 17, 2024 21:42
@bethshook
Copy link
Contributor

@vcstax should the label here be in red as well?

@vcstax
Copy link

vcstax commented Oct 21, 2024

@bethshook Yes. In Assignable's case, the option text is actually styled like a field label. The final product should look like this.
checked-error

The disabled state will be the normal unchecked style at 40% opacity
unchecked-disabled

unCheckedBorder: `1px solid ${colors.palette.lightRed}`,
checkedBorder: `1px solid ${colors.palette.lightRed}`,
backgroundImage: 'data:image/svg+xml,<svg height="125px" width="125px" version="1.1" id="Capa_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 17.837 17.837" xml:space="preserve" fill="%23000000"><g id="SVGRepo_bgCarrier" stroke-width="0"></g><g id="SVGRepo_tracerCarrier" stroke-linecap="round" stroke-linejoin="round"></g><g id="SVGRepo_iconCarrier"><g><path style="fill:%23C22032;" d="M16.145,2.571c-0.272-0.273-0.718-0.273-0.99,0L6.92,10.804l-4.241-4.27 c-0.272-0.274-0.715-0.274-0.989,0L0.204,8.019c-0.272,0.271-0.272,0.717,0,0.99l6.217,6.258c0.272,0.271,0.715,0.271,0.99,0 L17.63,5.047c0.276-0.273,0.276-0.72,0-0.994L16.145,2.571z"></path></g></g></svg>'
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind creating an icons file somewhere (unless it already exists) and importing the svgs as named icons

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants