-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error styling updates #58
Conversation
Screenshot of what the error styled checkbox / message looks like checked: The color scheme / style in the figma file didn't provide a checked error style. I opted for the red listed in the issue description ( Additionally, I mirrored the pattern used for the |
@vcstax should the label here be in red as well? |
@bethshook Yes. In Assignable's case, the option text is actually styled like a field label. The final product should look like this. The disabled state will be the normal unchecked style at 40% opacity |
unCheckedBorder: `1px solid ${colors.palette.lightRed}`, | ||
checkedBorder: `1px solid ${colors.palette.lightRed}`, | ||
backgroundImage: 'data:image/svg+xml,<svg height="125px" width="125px" version="1.1" id="Capa_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" viewBox="0 0 17.837 17.837" xml:space="preserve" fill="%23000000"><g id="SVGRepo_bgCarrier" stroke-width="0"></g><g id="SVGRepo_tracerCarrier" stroke-linecap="round" stroke-linejoin="round"></g><g id="SVGRepo_iconCarrier"><g><path style="fill:%23C22032;" d="M16.145,2.571c-0.272-0.273-0.718-0.273-0.99,0L6.92,10.804l-4.241-4.27 c-0.272-0.274-0.715-0.274-0.989,0L0.204,8.019c-0.272,0.271-0.272,0.717,0,0.99l6.217,6.258c0.272,0.271,0.715,0.271,0.99,0 L17.63,5.047c0.276-0.273,0.276-0.72,0-0.994L16.145,2.571z"></path></g></g></svg>' | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you mind creating an icons file somewhere (unless it already exists) and importing the svgs as named icons
https://openstax.atlassian.net/browse/CORE-506