feature: add link issues check #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philschatz
reviewed
Feb 5, 2020
src/utils/getConnectedIssueForPR.js
Outdated
| * which is an error that cannot be suppressed | ||
| **/ | ||
| /* eslint-disable-next-line */ | ||
| '^(.* )?link: (?<owner>openstax)\/(?<repo>[a-z\-]+)#(?<number>[0-9]+)( .*)?$', |
There was a problem hiding this comment.
Why is the text link: necessary? If it is to differentiate from someone saying something like This is a followup to #123 then maybe additional phrases should be included. Examples
refs #123fixes openstax/foo#123
There was a problem hiding this comment.
yea i agree that the word "link" could be better. maybe just for: openstax/foo#123 would be clearer
philschatz
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This verifies that the Pull Request description contains a link to the Issue that it fixes.