Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade probot & add merging bases #73

Merged
merged 32 commits into from
Feb 5, 2020
Merged

Upgrade probot & add merging bases #73

merged 32 commits into from
Feb 5, 2020

Conversation

TomWoodward
Copy link
Member

@TomWoodward TomWoodward commented Jan 31, 2020 •
edited
Loading

automatically update PRs when their base branch has new commits (this will naturally trigger the checks to run again)

@staxly
Copy link

staxly bot commented Jan 31, 2020

The maintainers of this repository would appreciate it if you could provide more information.

@staxly
Copy link

staxly bot commented Jan 31, 2020

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • Fix any tests that fail
  • Document any user-facing changes you've made
  • Include tests when adding/changing behavior
  • Include screenshots and animated GIFs whenever possible

@philschatz philschatz temporarily deployed to staxly-dev-pr-73 January 31, 2020 18:55 Inactive
@philschatz philschatz temporarily deployed to staxly-dev-pr-73 January 31, 2020 18:59 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 19:04 Inactive
@TomWoodward TomWoodward changed the title merging bases wip - merging bases Jan 31, 2020
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 19:23 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 19:41 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 19:55 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 20:05 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 20:08 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 20:41 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 20:44 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 20:49 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 21:33 Inactive
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 21:38 Inactive
@TomWoodward TomWoodward changed the title wip - merging bases merging bases Jan 31, 2020
@TomWoodward TomWoodward temporarily deployed to staxly-dev-pr-73 January 31, 2020 21:48 Inactive
@philschatz philschatz temporarily deployed to staxly-dev-pr-73 January 31, 2020 22:14 Inactive
@philschatz philschatz temporarily deployed to staxly-dev-pr-73 January 31, 2020 22:24 Inactive
@philschatz philschatz temporarily deployed to staxly-dev-pr-73 January 31, 2020 23:13 Inactive
@philschatz philschatz changed the title merging bases Upgrade probot & add merging bases Jan 31, 2020
@TomWoodward
Copy link
Member Author

@philschatz i looked at your new commits and they seem good, are we ready to merge this?

@philschatz philschatz self-requested a review February 4, 2020 20:46
@philschatz philschatz merged commit c27f53b into master Feb 5, 2020
@staxly
Copy link

staxly bot commented Feb 5, 2020

Congrats on merging your first pull request! 🎉🎉🎉

@philschatz philschatz deleted the merge-bases branch February 5, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philschatz philschatz philschatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomWoodward @philschatz