Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint settings and fix errors #2383

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Jan 8, 2025

CORE-674
In addition to fixing uses of any, there were a few non-null assertions that I changed to casts. If that seems pointless, I could disable the rule and change the casts back to assertions.

@TomWoodward TomWoodward temporarily deployed to rex-web-use-eslint-reac-xs8d0h January 8, 2025 13:18 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-eslint-react-plugins branch from 279b7a4 to c39d22b Compare January 8, 2025 17:55
@TomWoodward TomWoodward temporarily deployed to rex-web-use-eslint-reac-xs8d0h January 8, 2025 17:55 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-eslint-react-plugins branch from c39d22b to 18f34b0 Compare January 8, 2025 18:09
@TomWoodward TomWoodward temporarily deployed to rex-web-use-eslint-reac-xs8d0h January 8, 2025 18:10 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-eslint-react-plugins branch from 18f34b0 to 3a56da8 Compare January 8, 2025 18:11
@TomWoodward TomWoodward temporarily deployed to rex-web-use-eslint-reac-xs8d0h January 8, 2025 18:12 Inactive
@RoyEJohnson RoyEJohnson marked this pull request as ready for review January 8, 2025 18:59
@RoyEJohnson RoyEJohnson requested a review from a team as a code owner January 8, 2025 18:59
@RoyEJohnson RoyEJohnson force-pushed the use-eslint-react-plugins branch from 3a56da8 to 9fe5034 Compare January 8, 2025 19:34
@TomWoodward TomWoodward temporarily deployed to rex-web-use-eslint-reac-xs8d0h January 8, 2025 19:35 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-eslint-reac-xs8d0h January 8, 2025 20:41 Inactive
Copy link
Member

@TomWoodward TomWoodward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me as long as the types are all still working right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants