Update packages #2337
Merged
Update packages #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
update-packages
branch
from
9af911f to
cbd0a62
Compare
Somehow introduces ts lint issue in prerender/fleet.ts
RoyEJohnson
force-pushed
the
update-packages
branch
from
578ea2e to
1b4f781
Compare
Dantemss
requested changes
Sep 16, 2024
| @@ -396,9 +396,9 @@ async function waitUntilWorkDone( | |||
| '[SQS] [GetQueueAttributes] Unexpected response: missing Attributes key' | |||
| ); | |||
|
|
|||
| const numMessages = parseInt(attributes.ApproximateNumberOfMessages, 10) + | |||
| parseInt(attributes.ApproximateNumberOfMessagesDelayed, 10) + | |||
| parseInt(attributes.ApproximateNumberOfMessagesNotVisible, 10); | |||
There was a problem hiding this comment.
I'd say it's probably better to just use assertDefined for each of these 3 like the attributes key above, just in case...
| "@smithy/util-middleware" "^2.2.0" | ||
| "@smithy/util-retry" "^2.2.0" | ||
| "@smithy/util-utf8" "^2.3.0" | ||
| tslib "^2.6.2" | ||
|
|
||
| "@aws-sdk/client-dynamodb@^3.171.0": |
There was a problem hiding this comment.
This one didn't get updated for some reason, idk if it's something we want to figure out?
There was a problem hiding this comment.
% yarn why @aws-sdk/client-dynamodb
yarn why v1.22.22
[1/4] 🤔 Why do we have the module "@aws-sdk/client-dynamodb"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "@aws-sdk/[email protected]"
info Reasons this module exists
- "@openstax#ts-utils" depends on it
- Hoisted from "@openstax#ts-utils#@aws-sdk#client-dynamodb"
| "@smithy/util-middleware" "^2.2.0" | ||
| "@smithy/util-retry" "^2.2.0" | ||
| "@smithy/util-utf8" "^2.3.0" | ||
| tslib "^2.6.2" | ||
|
|
||
| "@aws-sdk/[email protected]", "@aws-sdk/client-sts@^3.171.0": |
There was a problem hiding this comment.
This is another indirect dependency through ts-utils. Our version of Node precludes upgrading @openstax/ts-utils (requires 16 or higher).
Dantemss
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CORE-495
This PR is intended to upgrade packages that have gotten out of date. Most of the changes are in the yarn.lock.
Notable: @AWS-SDK packages are limited due to the old version of node we use. package.json is updated to mark that limitation.