improve contrast on button focus outline #2258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 17, 2024 10:27
jivey
approved these changes
Jun 24, 2024
jivey
reviewed
Jun 24, 2024
src/app/components/Button.tsx
Outdated
|
|
||
| &:focus { | ||
| outline: solid ${theme.color.white}; | ||
| box-shadow: inset 0 0 0 3px ${theme.color.black}; |
There was a problem hiding this comment.
There's a defaultFocusOutline style in src/app/theme.ts that you might consider. It tries to make the outline the same as the browser default. Of course, black and white will give you maximum contrast.
There was a problem hiding this comment.
that's good to know but this change is actually in response to a browser default - one of them is too close to the orange of this button
added 2 commits
June 24, 2024 10:32
RoyEJohnson
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/DISCO-216