Update assignable launch #2253
Update assignable launch #2253
Conversation
|
|
||
| jest.mock('react', () => { | ||
| const react = (jest as any).requireActual('react'); | ||
| return { ...react, useEffect: react.useLayoutEffect }; |
There was a problem hiding this comment.
I see that swapping this makes it synchronous, but I can't tell why at a glance. Is act not sufficient?
There was a problem hiding this comment.
its possible that newer versions of react or the testing library don't have this problem, but there are a few places in the rex code that do this. the react issue is here facebook/react#14050 (comment)
| @@ -39,21 +42,60 @@ const StyledSectionTitle = styled.h2` | |||
| `)} | |||
| `; | |||
|
|
|||
| declare const window: any; | |||
There was a problem hiding this comment.
I don't notice any custom properties so it seems like you wouldn't need it this.... maybe prerendering related?
There was a problem hiding this comment.
looks like an artifact of an earlier age
src/app/content/launchToken.ts
Outdated
| export const pullToken = (window: Window) => { | ||
| const searchParams = new URLSearchParams(window.location.search); | ||
|
|
||
| const launchToken = searchParams.get('t') ?? undefined; |
There was a problem hiding this comment.
The ?? branch seems pointless.
There was a problem hiding this comment.
you're right, the conditional below catches it either way
https://openstax.atlassian.net/browse/DISCO-14
adds token parsing for assignable integration and textSize support from the assignable nav. integrates with changes from https://github.com/openstax/assignments/compare/main...text-resizer?expand=1