Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure lazy loaded images load when visible initially #2249

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Ensure lazy loaded images load when visible initially #2249

merged 1 commit into from
Jun 13, 2024

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented May 31, 2024 •
edited
Loading

DISCO-285

Lazy loaded items don't always notice that they're visible. There was a check already for when the component updated, but that doesn't fire on initial load, so it had to be added to ComponentDidMount as well.

@TomWoodward TomWoodward temporarily deployed to rex-web-load-lazy-image-wgmaee May 31, 2024 15:21 Inactive
@RoyEJohnson RoyEJohnson force-pushed the load-lazy-images-when-visible-on-initial-load branch from 730f012 to 5bcf569 Compare May 31, 2024 15:50
@TomWoodward TomWoodward temporarily deployed to rex-web-load-lazy-image-wgmaee May 31, 2024 15:50 Inactive
@RoyEJohnson RoyEJohnson marked this pull request as ready for review May 31, 2024 16:21
@RoyEJohnson RoyEJohnson requested a review from a team as a code owner May 31, 2024 16:21
@RoyEJohnson RoyEJohnson requested a review from jivey May 31, 2024 16:21
jivey
jivey approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I'm guessing this is from of a fixed "bug" in Chrome at some point? Seems like an good change to me, though you may want to update the PR title.

@RoyEJohnson RoyEJohnson changed the title Add debugging Fix lazy loading images failing to load initially Jun 10, 2024
@RoyEJohnson RoyEJohnson force-pushed the load-lazy-images-when-visible-on-initial-load branch from 5bcf569 to 97d9187 Compare June 10, 2024 14:59
@RoyEJohnson RoyEJohnson changed the title Fix lazy loading images failing to load initially Ensure lazy loaded images load when visible initially Jun 10, 2024
@RoyEJohnson
Check lazy load on mount
7be0510 
WIP not ready to merge
@RoyEJohnson RoyEJohnson force-pushed the load-lazy-images-when-visible-on-initial-load branch from 97d9187 to 7be0510 Compare June 10, 2024 15:00
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-load-lazy-image-ip9ssq June 11, 2024 18:14 Inactive
@Malar-Natarajan Malar-Natarajan merged commit f6221a6 into main Jun 13, 2024
8 of 9 checks passed
@Malar-Natarajan Malar-Natarajan deleted the load-lazy-images-when-visible-on-initial-load branch June 13, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
in-production
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@RoyEJohnson @jivey @TomWoodward @staxbot @Malar-Natarajan