Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix note indicator and tabbability #2223

Closed
wants to merge 10 commits into from
Closed

Fix note indicator and tabbability #2223

wants to merge 10 commits into from

Conversation

RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Apr 15, 2024 •
edited by jira bot
Loading

@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 15, 2024 20:56 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 87fcbf4 to f0b2bac Compare April 15, 2024 21:12
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 15, 2024 21:12 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from f0b2bac to 262eb1a Compare April 15, 2024 22:17
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 15, 2024 22:18 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 15, 2024 23:19 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 8fcce40 to 9f4a212 Compare April 16, 2024 22:24
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 16, 2024 22:25 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 16, 2024 22:38 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 16, 2024 22:51 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from b654cee to 3521a16 Compare April 16, 2024 23:22
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 16, 2024 23:23 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 17, 2024 13:27 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 27e6d25 to 5ddd7f5 Compare April 17, 2024 13:30
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 17, 2024 13:30 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 5ddd7f5 to d619194 Compare April 17, 2024 19:19
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 17, 2024 19:19 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from d619194 to 6391d8d Compare April 17, 2024 19:28
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 17, 2024 19:28 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 6391d8d to 538fd09 Compare April 17, 2024 19:32
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 17, 2024 19:32 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 538fd09 to 5726161 Compare April 22, 2024 16:33
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 22, 2024 16:34 Inactive
@RoyEJohnson RoyEJohnson marked this pull request as ready for review April 22, 2024 16:36
@RoyEJohnson RoyEJohnson requested a review from a team as a code owner April 22, 2024 16:36
@RoyEJohnson RoyEJohnson requested a review from jivey April 22, 2024 16:36
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 22, 2024 16:47 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 9c3e37a to 7756db6 Compare April 22, 2024 17:29
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 22, 2024 17:29 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx April 23, 2024 14:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx May 2, 2024 20:51 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx May 2, 2024 21:31 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx May 3, 2024 14:32 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx May 3, 2024 14:33 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-a7a6nx May 6, 2024 18:57 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-fix-non-tabbabl-6vp0jc May 16, 2024 18:36 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-fix-non-tabbabl-bctkst May 30, 2024 20:33 Inactive
@Malar-Natarajan Malar-Natarajan temporarily deployed to rex-web-fix-non-tabbabl-vapuqy May 30, 2024 20:39 Inactive
@Malar-Natarajan
Copy link
Contributor

@RoyEJohnson The tests are failing in this PR and the deployment is also failing. Could you please take a look.

@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 592f118 to 75a9cb3 Compare May 30, 2024 21:04
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-lhibd3 May 30, 2024 21:05 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-vwonjj May 30, 2024 21:11 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from f63d541 to 56b16c3 Compare May 31, 2024 17:55
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-vwonjj May 31, 2024 17:55 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-fix-non-tabbabl-vwonjj May 31, 2024 18:45 Inactive
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 969792d to 1cf927b Compare July 2, 2024 13:52
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from 11e0099 to b698544 Compare July 16, 2024 16:57
@RoyEJohnson RoyEJohnson force-pushed the fix-non-tabbable-highlights branch from ae19279 to 5b0238f Compare August 12, 2024 15:11
@RoyEJohnson
Copy link
Contributor Author

The changes I made to highlighter for this and related PRs seem to be ill-advised. There is another PR coming through that should address the aria-label issue and hopefully not introduce the other problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jivey jivey jivey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RoyEJohnson @Malar-Natarajan @jivey @TomWoodward