add chapter name and book title to attribution link #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
approved these changes
Apr 16, 2024
Malar-Natarajan
temporarily deployed
to
rex-web-attribution-lin-0ikhmv
|
@RoyEJohnson I missed a couple of other citation links that needed this aria label as well, if you don't mind taking another look |
RoyEJohnson
reviewed
May 1, 2024
| @@ -28,7 +28,7 @@ export const defaultText = ` | |||
| If you are redistributing all or part of this book in a digital format, | |||
| then you must include on every digital page view the following attribution: | |||
| <blockquote> | |||
| Access for free at <a target="_blank" href="https://openstax.org{introPageUrl}">https://openstax.org{introPageUrl}</a> | |||
| Access for free at <a target="_blank" href="https://openstax.org{introPageUrl}" aria-label="{introPageTitle}">https://openstax.org{introPageUrl}</a> | |||
There was a problem hiding this comment.
The quotes are superfluous, aren't they? Should just be aria-label={introPageTitle} ?
And the interpolation in the href? That works? I'd write
href={`https://openstax.org${introPageUrl}`}
There was a problem hiding this comment.
This string gets formatted with the useIntl stuff, so it's like how we interpolate in the messages.json file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/DISCO-84