Fix header and list-of-links structure in footer #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dantemss
approved these changes
Mar 26, 2024
src/app/components/Footer/index.tsx
Outdated
| function LinkList({children}: React.PropsWithChildren<{}>) { | ||
| return ( | ||
| <Styled.LinkListWrapper> | ||
| {React.Children.toArray(children).map((c) => <li>{c}</li>)} |
There was a problem hiding this comment.
I noticed this one doesn't set the key property, unlike the other PR
There was a problem hiding this comment.
Oh, yeah. No warning on the Rex system for that. The set of children won't be changing, but I pushed a use-index-as-key update.
RoyEJohnson
force-pushed
the
fix-header-structure-in-footer
branch
from
6ed788a to
0e1d986
Compare
Malar-Natarajan
temporarily deployed
to
rex-web-fix-header-stru-cjpa0u
RoyEJohnson
force-pushed
the
fix-header-structure-in-footer
branch
from
9e4dd5f to
56a2d22
Compare
RoyEJohnson
force-pushed
the
fix-header-structure-in-footer
branch
from
df9ef59 to
76a19e7
Compare
RoyEJohnson
force-pushed
the
fix-header-structure-in-footer
branch
from
712ddb0 to
45b9171
Compare
RoyEJohnson
force-pushed
the
fix-header-structure-in-footer
branch
from
45b9171 to
cefa592
Compare
|
@RoyEJohnson Lint is failing in this PR even after a re-run. Could you please look into it. |
RoyEJohnson
force-pushed
the
fix-header-structure-in-footer
branch
from
8f501a7 to
05f9011
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCO-44