Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mark tag for highlights #2176

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Use mark tag for highlights #2176

merged 10 commits into from
Apr 11, 2024

Conversation

@RoyEJohnson RoyEJohnson requested a review from a team as a code owner February 15, 2024 20:21
@RoyEJohnson RoyEJohnson requested a review from jivey February 15, 2024 20:21
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 15, 2024 20:22 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-mark-tag-for-highlights branch from 1d19243 to 296bb94 Compare February 15, 2024 20:23
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 15, 2024 20:23 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 15, 2024 20:43 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-mark-tag-for-highlights branch from c2c3919 to cd0d9d7 Compare February 15, 2024 21:36
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 15, 2024 21:37 Inactive
Copy link
Member

@jivey jivey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The es and pl translation placeholders need to be updated from english, did you want to place an automated translation in there for now and tag other people for review?

package.json Outdated Show resolved Hide resolved
@RoyEJohnson
Copy link
Contributor Author

RoyEJohnson commented Feb 19, 2024 via email

@RoyEJohnson RoyEJohnson force-pushed the use-mark-tag-for-highlights branch from cd0d9d7 to 82c33c9 Compare February 20, 2024 19:44
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 20, 2024 19:44 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-mark-tag-for-highlights branch from 82c33c9 to b3b023c Compare February 20, 2024 20:18
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 20, 2024 20:18 Inactive
@RoyEJohnson RoyEJohnson requested a review from jivey February 20, 2024 20:19
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 22, 2024 16:17 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 22, 2024 17:11 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 22, 2024 22:21 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 23, 2024 20:02 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 27, 2024 16:50 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-mark-tag-for-highlights branch from 04ad508 to aedbb57 Compare February 27, 2024 17:47
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 27, 2024 17:48 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 27, 2024 19:07 Inactive
@RoyEJohnson RoyEJohnson force-pushed the use-mark-tag-for-highlights branch 2 times, most recently from f6c501d to aeaccfb Compare February 27, 2024 20:38
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 27, 2024 20:38 Inactive
@RoyEJohnson RoyEJohnson requested a review from jivey February 27, 2024 20:41
@RoyEJohnson
Copy link
Contributor Author

@jivey The last commit addresses a separate but closely issue.

@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-l7awzi February 29, 2024 22:33 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-e3uxk0 April 9, 2024 19:42 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-e3uxk0 April 9, 2024 20:02 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-e3uxk0 April 10, 2024 13:59 Inactive
@TomWoodward TomWoodward temporarily deployed to rex-web-use-mark-tag-fo-e3uxk0 April 10, 2024 19:16 Inactive
@Malar-Natarajan Malar-Natarajan merged commit d9858ae into main Apr 11, 2024
8 of 9 checks passed
@Malar-Natarajan Malar-Natarajan deleted the use-mark-tag-for-highlights branch April 11, 2024 14:12
RoyEJohnson added a commit that referenced this pull request Apr 17, 2024
RoyEJohnson added a commit that referenced this pull request Apr 22, 2024
Dantemss pushed a commit that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants