-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use mark tag for highlights #2176
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoyEJohnson
force-pushed
the
use-mark-tag-for-highlights
branch
from
February 15, 2024 20:23
1d19243
to
296bb94
Compare
RoyEJohnson
force-pushed
the
use-mark-tag-for-highlights
branch
from
February 15, 2024 21:36
c2c3919
to
cd0d9d7
Compare
jivey
requested changes
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The es and pl translation placeholders need to be updated from english, did you want to place an automated translation in there for now and tag other people for review?
RoyEJohnson
force-pushed
the
use-mark-tag-for-highlights
branch
from
February 20, 2024 19:44
cd0d9d7
to
82c33c9
Compare
RoyEJohnson
force-pushed
the
use-mark-tag-for-highlights
branch
from
February 20, 2024 20:18
82c33c9
to
b3b023c
Compare
jivey
approved these changes
Feb 21, 2024
RoyEJohnson
force-pushed
the
use-mark-tag-for-highlights
branch
from
February 27, 2024 17:47
04ad508
to
aedbb57
Compare
RoyEJohnson
force-pushed
the
use-mark-tag-for-highlights
branch
2 times, most recently
from
February 27, 2024 20:38
f6c501d
to
aeaccfb
Compare
@jivey The last commit addresses a separate but closely issue. |
RoyEJohnson
added a commit
that referenced
this pull request
Apr 17, 2024
This reverts commit d9858ae.
RoyEJohnson
added a commit
that referenced
this pull request
Apr 22, 2024
This reverts commit d9858ae.
Dantemss
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For: https://github.com/openstax/unified/issues/2647
For: https://openstax.atlassian.net/browse/DISCO-111
For: https://github.com/openstax/unified/issues/2718
For: https://github.com/openstax/unified/issues/2792
For: https://openstax.atlassian.net/browse/DISCO-120
For: https://openstax.atlassian.net/browse/DISCO-152
Note 25-Mar
The PR is now using a Highlighter release tag and can be merged whenever.